extensions/renderer/extension_frame_helper.cc - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/extension_frame_helper.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/extension_frame_helper.cc

diff --git a/extensions/renderer/extension_frame_helper.cc b/extensions/renderer/extension_frame_helper.cc

index c737aa55caf35aefebae34681f3882dd76126cb9..3985bd60efd97f85ff90275b22243f5c28c92ac9 100644

--- a/extensions/renderer/extension_frame_helper.cc

+++ b/extensions/renderer/extension_frame_helper.cc

@@ -187,7 +187,8 @@ void ExtensionFrameHelper::DidMatchCSS(

stopped_matching_selectors);

}

-void ExtensionFrameHelper::DidStartProvisionalLoad() {

+void ExtensionFrameHelper::DidStartProvisionalLoad(

+ blink::WebDataSource* data_source) {

if (!delayed_main_world_script_initialization_)

return;