components/test_runner/web_frame_test_client.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_frame_test_client.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/web_frame_test_client.h

diff --git a/components/test_runner/web_frame_test_client.h b/components/test_runner/web_frame_test_client.h

index 27cb35a42391cdbb098934ddb9f723c5a1cb009c..68dc7f7c6097bac569a71c0b9f69654f00dc7f19 100644

--- a/components/test_runner/web_frame_test_client.h

+++ b/components/test_runner/web_frame_test_client.h

@@ -61,7 +61,7 @@ class WebFrameTestClient : public blink::WebFrameClient {

const blink::WebString& suggested_name,

bool replaces_current_history_item) override;

void loadErrorPage(int reason) override;

- void didStartProvisionalLoad(blink::WebLocalFrame* frame) override;

+ void didStartProvisionalLoad(blink::WebDataSource* data_source) override;

void didReceiveServerRedirectForProvisionalLoad(

blink::WebLocalFrame* frame) override;

void didFailProvisionalLoad(blink::WebLocalFrame* frame,