components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/renderer/subresource_filter_agent.cc ('k') | components/test_runner/web_frame_test_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

index 7a8b9bd0c20343610ca1fab1e3bace2f9afd7cf0..f6eb58bfca55c9e6aec1e6d3cb833464d729909e 100644

--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

@@ -121,13 +121,13 @@ class SubresourceFilterAgentTest : public ::testing::Test {

}

void StartLoadWithoutSettingActivationLevel() {

- agent_as_rfo()->DidStartProvisionalLoad();

+ agent_as_rfo()->DidStartProvisionalLoad(nullptr);

agent_as_rfo()->DidCommitProvisionalLoad(

true /* is_new_navigation */, false /* is_same_page_navigation */);

}

void PerformSamePageNavigationWithoutSettingActivationLevel() {

- agent_as_rfo()->DidStartProvisionalLoad();

+ agent_as_rfo()->DidStartProvisionalLoad(nullptr);

agent_as_rfo()->DidCommitProvisionalLoad(

true /* is_new_navigation */, true /* is_same_page_navigation */);

// No DidFinishLoad is called in this case.

@@ -135,7 +135,7 @@ class SubresourceFilterAgentTest : public ::testing::Test {

void StartLoadAndSetActivationLevel(ActivationLevel activation_level,

bool measure_performance = false) {

- agent_as_rfo()->DidStartProvisionalLoad();

+ agent_as_rfo()->DidStartProvisionalLoad(nullptr);

EXPECT_TRUE(agent_as_rfo()->OnMessageReceived(

SubresourceFilterMsg_ActivateForProvisionalLoad(

0, activation_level, GURL(), measure_performance)));

@@ -394,11 +394,11 @@ TEST_F(SubresourceFilterAgentTest,

ASSERT_NO_FATAL_FAILURE(

SetTestRulesetToDisallowURLsWithPathSuffix(kTestBothURLsPathSuffix));

ExpectNoSubresourceFilterGetsInjected();

- agent_as_rfo()->DidStartProvisionalLoad();

+ agent_as_rfo()->DidStartProvisionalLoad(nullptr);

EXPECT_TRUE(agent_as_rfo()->OnMessageReceived(

SubresourceFilterMsg_ActivateForProvisionalLoad(

0, ActivationLevel::ENABLED, GURL(), true)));

- agent_as_rfo()->DidStartProvisionalLoad();

+ agent_as_rfo()->DidStartProvisionalLoad(nullptr);

agent_as_rfo()->DidCommitProvisionalLoad(true /* is_new_navigation */,

false /* is_same_page_navigation */);

FinishLoad();