components/contextual_search/renderer/overlay_js_render_frame_observer.h - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/contextual_search/renderer/overlay_js_render_frame_observer.h

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/password_autofill_agent.cc ('k') | components/contextual_search/renderer/overlay_js_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/contextual_search/renderer/overlay_js_render_frame_observer.h

diff --git a/components/contextual_search/renderer/overlay_js_render_frame_observer.h b/components/contextual_search/renderer/overlay_js_render_frame_observer.h

index 595cea39409ebc1d9de222d152ed638c42afc422..53a7c870be1f475b2f54e8ad4c2a69406d8f90e3 100644

--- a/components/contextual_search/renderer/overlay_js_render_frame_observer.h

+++ b/components/contextual_search/renderer/overlay_js_render_frame_observer.h

@@ -25,7 +25,7 @@ class OverlayJsRenderFrameObserver : public content::RenderFrameObserver {

~OverlayJsRenderFrameObserver() override;

// RenderFrameObserver implementation.

- void DidStartProvisionalLoad() override;

+ void DidStartProvisionalLoad(blink::WebDataSource* data_source) override;

void DidClearWindowObject() override;

void DidFinishLoad() override;