Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)
Patch Set: Remove CHECK for redirect chain as the redirects may not be populated for provisional loads for ren… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 69a16f4d6ebf9c48a53057358509d638ba1d2b2d..c0f4472bf82f7994cf80a9b04a339cc7f02eba8a 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -1167,7 +1167,8 @@ void PasswordAutofillAgent::OnDestruct() {
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
}
-void PasswordAutofillAgent::DidStartProvisionalLoad() {
+void PasswordAutofillAgent::DidStartProvisionalLoad(
+ blink::WebDataSource* data_source) {
std::unique_ptr<RendererSavePasswordProgressLogger> logger;
if (logging_state_active_) {
logger.reset(new RendererSavePasswordProgressLogger(
@@ -1186,8 +1187,7 @@ void PasswordAutofillAgent::DidStartProvisionalLoad() {
// the user is performing actions outside the page (e.g. typed url,
// history navigation). We don't want to trigger saving in these cases.
content::DocumentState* document_state =
- content::DocumentState::FromDataSource(
- navigated_frame->provisionalDataSource());
+ content::DocumentState::FromDataSource(data_source);
content::NavigationState* navigation_state =
document_state->navigation_state();
ui::PageTransition type = navigation_state->GetTransitionType();

Powered by Google App Engine
This is Rietveld 408576698