third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Fix compile failures Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html ('K') | « third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

index 67c6163ab52a03be8f2e45be2e5a44e0ae4f1a71..1694c8df370b2681e5c3c86fcd1edc4ad65575c7 100644

--- a/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp

@@ -48,7 +48,8 @@ class TestDocumentSubresourceFilter : public WebDocumentSubresourceFilter {

class SubresourceFilteringWebFrameClient

: public FrameTestHelpers::TestWebFrameClient {

public:

- void didStartProvisionalLoad(WebLocalFrame* localFrame) override {

+ void didStartProvisionalLoad(WebLocalFrame* localFrame,

+ WebDataSource* dataSource) override {

// Normally, the filter should be set when the load is committed. For

// the sake of this test, however, inject it earlier to verify that it

// is not consulted for the main resource load.