third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html - Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html

Issue 2661743002: PlzNavigate: Invoke didStartProvisionalLoad() when the renderer initiates a navigation in startLoad( (Closed)

Patch Set: Fix compile failures Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html b/third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html

index 5511fe565db13719f110fa1c67ed1fda97ceae72..991edd8dbdae7556460e30a00c4f59d6f8538bf6 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/back-to-dynamic-iframe.html

@@ -8,11 +8,11 @@ if (window.testRunner) {

function childLoaded() {

if (window.sessionStorage.getItem("dynamic-iframe") != null) {

- setTimeout(function() {

+ setTimeout(function () {

Nate Chapin 2017/02/03 00:17:38 The changes in this file look accidental?

ananta 2017/02/03 01:35:14 Yes. Reverted

location.assign("resources/go-back.html");

}, 0);

} else {

- setTimeout(function() {

+ setTimeout(function () {

if (window.testRunner)

testRunner.notifyDone();

}, 0);

@@ -27,7 +27,7 @@ if (window.sessionStorage.getItem("dynamic-iframe") == null) {

window.sessionStorage.setItem("dynamic-iframe", true);

i.src = "resources/back-to-dynamic-iframe-iframe.html#FAIL";

} else {

- window.sessionStorage.removeItem("dynamic-iframe");

+ window.sessionStorage.removeItem("dynamic-iframe");

i.src = "resources/back-to-dynamic-iframe-iframe.html#PASS";

}

</script>