Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2661693002: Convert SaveCardBubbleControllerImpl to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SaveCardBubbleControllerImpl to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2661693002 Cr-Commit-Position: refs/heads/master@{#447052} Committed: https://chromium.googlesource.com/chromium/src/+/d9ffd1b220d31b7fd2fab3b1c1cb9513cafb99be

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc View 1 6 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
jam
3 years, 10 months ago (2017-01-30 19:03:48 UTC) #16
Mathieu
lgtm, I trust the new way is equivalent? Any subtlety we should be aware of?
3 years, 10 months ago (2017-01-30 19:08:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661693002/20001
3 years, 10 months ago (2017-01-30 20:28:45 UTC) #19
jam
On 2017/01/30 19:08:10, Mathieu Perreault wrote: > lgtm, > > I trust the new way ...
3 years, 10 months ago (2017-01-30 20:28:50 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:34:38 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d9ffd1b220d31b7fd2fab3b1c1cb...

Powered by Google App Engine
This is Rietveld 408576698