Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2661683002: [Telemetry] Add web_contents.WaitForJavaScriptCondition method (Closed)

Created:
3 years, 10 months ago by perezju
Modified:
3 years, 10 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org, achuithb
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Add web_contents.WaitForJavaScriptCondition method The method name is provided for ChromeOS clients to ease their trainsition into the new API. BUG=chromium:682812 Review-Url: https://codereview.chromium.org/2661683002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9907db54ee404c8a3efb585fa7db4c58e6966ef3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M telemetry/telemetry/internal/browser/web_contents.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
perezju
+achuith FYI
3 years, 10 months ago (2017-01-27 19:21:29 UTC) #2
nednguyen
lgtm
3 years, 10 months ago (2017-01-27 19:22:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661683002/1
3 years, 10 months ago (2017-01-27 19:29:07 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 19:49:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698