Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2661663004:
Remove unused out-of-process file patching IPC handlers (Closed)
|
Created:
3 years, 10 months ago by Noel Gordon Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unused out-of-process file patching IPC handlers
OnPatchFileBsdiff and OnPatchFileCourgette are no longer used and have
no corresponding definition. Remove them.
TBR=jochen@chromium.org
BUG=597124
Review-Url: https://codereview.chromium.org/2661663004
Cr-Commit-Position: refs/heads/master@{#447694}
Committed: https://chromium.googlesource.com/chromium/src/+/fe451778fade1e59bd5c422833795f0836ef08a2
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
noel@chromium.org changed reviewers: + waffles@chromium.org
The out-of-process file patcher seems ok since we converted it to use mojo a week ago. So far, so good. The code being removed here is no longer used now we are using mojo. PTAL.
noel@chromium.org changed reviewers: + sammc@chromium.org, tibell@chromium.org
lgtm
lgtm
noel@chromium.org changed reviewers: + jochen@chromium.org
+jochen for OWNERS.
lgtm
Description was changed from ========== Remove unused out-of-process file patching IPC handlers OnPatchFileBsdiff and OnPatchFileCourgette are no longer used and have no corresponding definition. Remove them. BUG=597124 ========== to ========== Remove unused out-of-process file patching IPC handlers OnPatchFileBsdiff and OnPatchFileCourgette are no longer used and have no corresponding definition. Remove them. TBR=jochen@chromium.org BUG=597124 ==========
Think jochen is busy with BlinkOn, talk later.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485999481485360, "parent_rev":
"34be2d9f24b8c8b4056eba4d477321762bb783df", "commit_rev":
"fe451778fade1e59bd5c422833795f0836ef08a2"}
Message was sent while issue was closed.
Description was changed from ========== Remove unused out-of-process file patching IPC handlers OnPatchFileBsdiff and OnPatchFileCourgette are no longer used and have no corresponding definition. Remove them. TBR=jochen@chromium.org BUG=597124 ========== to ========== Remove unused out-of-process file patching IPC handlers OnPatchFileBsdiff and OnPatchFileCourgette are no longer used and have no corresponding definition. Remove them. TBR=jochen@chromium.org BUG=597124 Review-Url: https://codereview.chromium.org/2661663004 Cr-Commit-Position: refs/heads/master@{#447694} Committed: https://chromium.googlesource.com/chromium/src/+/fe451778fade1e59bd5c42283379... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/fe451778fade1e59bd5c42283379... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
