PlzNavigate: handle reload bypassing cache from the renderer

PlzNavigate: handle reload bypassing cache from the renderer

This CL ensures that renderer-initiated reloads that bypass cache are
correctly classified when being sent to the browser. This will ensure
the appropriate FrameLoadType will be set when they commit.

BUG=551000
Review-Url: https://codereview.chromium.org/2661643002
Cr-Commit-Position: refs/heads/master@{#448591}
Committed: https://chromium.googlesource.com/chromium/src/+/909133789bd254c0897c509d011571db4193d830

[clamy, 2017-01-27 16:12:40]

The CQ bit was checked by clamy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 16:12:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:44:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:44:59]

Dry run: This issue passed the CQ dry run.

[clamy, 2017-01-31 00:22:32]

Description was changed from

==========
PlzNavigate: handle reload bypassing cache from the renderer

This CL ensures that renderer-initiated reloads that bypass cache are
correctly classified when being sent to the browser. This will ensure
the appropriate FrameLoadType will be set when they commit.

BUG=551000
==========

to

==========
PlzNavigate: handle reload bypassing cache from the renderer

This CL ensures that renderer-initiated reloads that bypass cache are
correctly classified when being sent to the browser. This will ensure
the appropriate FrameLoadType will be set when they commit.

BUG=551000
==========

[clamy, 2017-01-31 00:22:32]

clamy@chromium.org changed reviewers:
+ dgozman@chromium.org

[clamy, 2017-01-31 00:23:10]

@dgozman: PTAL. This fixes the issue in PlzNavigate where we don't support
DevTools reload bypassing cache properly.

[dgozman, 2017-01-31 04:26:43]

lgtm

https://codereview.chromium.org/2661643002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2661643002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:642: navigation_type = 
FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE;
nit: extra space after '=' here and below

[clamy, 2017-02-07 09:29:06]

Thanks!

https://codereview.chromium.org/2661643002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2661643002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:642: navigation_type = 
FrameMsg_Navigate_Type::RELOAD_BYPASSING_CACHE;
On 2017/01/31 04:26:42, dgozman (OOO till Feb 13) wrote:
> nit: extra space after '=' here and below

Done.

[clamy, 2017-02-07 09:29:12]

The CQ bit was checked by clamy@chromium.org

[clamy, 2017-02-07 09:29:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2661643002/#ps20001
(title: "Rebase + addressed comments")

[commit-bot: I haz the power, 2017-02-07 09:29:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 10:53:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486459752021730,
"parent_rev": "a3379f65acf813392f6c30c38602774faad9caae", "commit_rev":
"909133789bd254c0897c509d011571db4193d830"}

[commit-bot: I haz the power, 2017-02-07 10:54:23]

Description was changed from

==========
PlzNavigate: handle reload bypassing cache from the renderer

This CL ensures that renderer-initiated reloads that bypass cache are
correctly classified when being sent to the browser. This will ensure
the appropriate FrameLoadType will be set when they commit.

BUG=551000
==========

to

==========
PlzNavigate: handle reload bypassing cache from the renderer

This CL ensures that renderer-initiated reloads that bypass cache are
correctly classified when being sent to the browser. This will ensure
the appropriate FrameLoadType will be set when they commit.

BUG=551000

Review-Url: https://codereview.chromium.org/2661643002
Cr-Commit-Position: refs/heads/master@{#448591}
Committed:
https://chromium.googlesource.com/chromium/src/+/909133789bd254c0897c509d0115...
==========

[commit-bot: I haz the power, 2017-02-07 10:54:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/909133789bd254c0897c509d0115...