Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 26616002: Mark spawnFunction tests as Fail on Dartium (Closed)

Created:
7 years, 2 months ago by vsm
Modified:
7 years, 2 months ago
Reviewers:
floitsch, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark spawnFunction tests as Fail on Dartium See corresponding Dartium CL: https://chromiumcodereview.appspot.com/26397003/ This disables spawnFunction on DOM enabled isolate (i.e., where dart:html is available). spawnFunction should continue to work on non-DOM enabled isolated. spawnUri should be unaffected. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28406

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add issue number #

Patch Set 3 : Mark more tests fail #

Patch Set 4 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M pkg/pkg.status View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +30 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vsm
7 years, 2 months ago (2013-10-08 23:25:46 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/26616002/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://chromiumcodereview.appspot.com/26616002/diff/1/tests/isolate/isolate.status#newcode140 tests/isolate/isolate.status:140: unresolved_ports_test: Fail I think we should change these ...
7 years, 2 months ago (2013-10-08 23:51:57 UTC) #2
vsm
https://chromiumcodereview.appspot.com/26616002/diff/1/tests/isolate/isolate.status File tests/isolate/isolate.status (right): https://chromiumcodereview.appspot.com/26616002/diff/1/tests/isolate/isolate.status#newcode140 tests/isolate/isolate.status:140: unresolved_ports_test: Fail On 2013/10/08 23:51:57, siva wrote: > I ...
7 years, 2 months ago (2013-10-09 05:00:49 UTC) #3
vsm
PTAL I had to mark several more tests fail across different suites.
7 years, 2 months ago (2013-10-09 16:00:09 UTC) #4
siva
On 2013/10/09 16:00:09, vsm wrote: > PTAL > > I had to mark several more ...
7 years, 2 months ago (2013-10-09 16:08:03 UTC) #5
vsm
PTAL. Re-uploaded.
7 years, 2 months ago (2013-10-09 16:15:28 UTC) #6
siva
lgtm
7 years, 2 months ago (2013-10-09 16:21:05 UTC) #7
vsm
7 years, 2 months ago (2013-10-09 16:25:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r28406 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698