Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 2661583002: Check the existence of each properties of ResourceDevToolsInfo for NavigationPreload (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the existence of each properties of ResourceDevToolsInfo for NavigationPreload According to buildObjectForResourceRequest() in InspectorNetworkAgent.cpp, those properties could be empty, even if devtools_info exists. BUG=649558 Review-Url: https://codereview.chromium.org/2661583002 Cr-Commit-Position: refs/heads/master@{#446600} Committed: https://chromium.googlesource.com/chromium/src/+/be58f69be3a0d8f714293bd03e6a57f1f88ca720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M content/browser/devtools/protocol/network_handler.cc View 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
horo
Please review this. Thank you.
3 years, 11 months ago (2017-01-27 03:40:13 UTC) #6
pfeldman
lgtm
3 years, 11 months ago (2017-01-27 03:52:37 UTC) #7
horo
Thank you!
3 years, 11 months ago (2017-01-27 04:06:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661583002/20001
3 years, 11 months ago (2017-01-27 04:07:25 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 05:12:03 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/be58f69be3a0d8f714293bd03e6a...

Powered by Google App Engine
This is Rietveld 408576698