|
|
Descriptionwin: Fix flaky compile failures.
content_main_runner.cc has a dependency on gpu_process_host.h, which has
a dependency on a mojom-generated header file. But this dependency is
required only in a non-multi-dll build. So add the proper #ifdef's to
make sure the problematic dependencies are avoided in multi-dll build.
BUG=685440
Review-Url: https://codereview.chromium.org/2661563002
Cr-Commit-Position: refs/heads/master@{#447027}
Committed: https://chromium.googlesource.com/chromium/src/+/e0d5a0de9a938f88ae2f9fe35b5186b352ca6021
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 21 (14 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sadrul@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping /cc+ dpranke@
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
sadrul@chromium.org changed reviewers: + jam@chromium.org
+jam@ as alternate content/ owner
lgtm
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485799435504410, "parent_rev": "54a832541cb8aafced2f60deb296132c90ad1eb4", "commit_rev": "e0d5a0de9a938f88ae2f9fe35b5186b352ca6021"}
Message was sent while issue was closed.
Description was changed from ========== win: Fix flaky compile failures. content_main_runner.cc has a dependency on gpu_process_host.h, which has a dependency on a mojom-generated header file. But this dependency is required only in a non-multi-dll build. So add the proper #ifdef's to make sure the problematic dependencies are avoided in multi-dll build. BUG=685440 ========== to ========== win: Fix flaky compile failures. content_main_runner.cc has a dependency on gpu_process_host.h, which has a dependency on a mojom-generated header file. But this dependency is required only in a non-multi-dll build. So add the proper #ifdef's to make sure the problematic dependencies are avoided in multi-dll build. BUG=685440 Review-Url: https://codereview.chromium.org/2661563002 Cr-Commit-Position: refs/heads/master@{#447027} Committed: https://chromium.googlesource.com/chromium/src/+/e0d5a0de9a938f88ae2f9fe35b51... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/e0d5a0de9a938f88ae2f9fe35b51... |