Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2661563002: win: Fix flaky compile failures. (Closed)

Created:
3 years, 11 months ago by sadrul
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, brettw, jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Fix flaky compile failures. content_main_runner.cc has a dependency on gpu_process_host.h, which has a dependency on a mojom-generated header file. But this dependency is required only in a non-multi-dll build. So add the proper #ifdef's to make sure the problematic dependencies are avoided in multi-dll build. BUG=685440 Review-Url: https://codereview.chromium.org/2661563002 Cr-Commit-Position: refs/heads/master@{#447027} Committed: https://chromium.googlesource.com/chromium/src/+/e0d5a0de9a938f88ae2f9fe35b5186b352ca6021

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/app/content_main_runner.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
sadrul
3 years, 11 months ago (2017-01-27 02:23:53 UTC) #8
sadrul
ping /cc+ dpranke@
3 years, 10 months ago (2017-01-28 02:06:00 UTC) #11
Dirk Pranke
lgtm
3 years, 10 months ago (2017-01-28 02:30:13 UTC) #13
sadrul
+jam@ as alternate content/ owner
3 years, 10 months ago (2017-01-28 06:32:42 UTC) #15
jam
lgtm
3 years, 10 months ago (2017-01-30 18:01:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661563002/20001
3 years, 10 months ago (2017-01-30 18:04:41 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:09:47 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e0d5a0de9a938f88ae2f9fe35b51...

Powered by Google App Engine
This is Rietveld 408576698