Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2661483002: [csa] Make argc parameter to CodeStubArguments constructor use ParameterMode (Closed)

Created:
3 years, 11 months ago by danno
Modified:
3 years, 10 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] Make argc parameter to CodeStubArguments constructor use ParameterMode Review-Url: https://codereview.chromium.org/2661483002 Cr-Commit-Position: refs/heads/master@{#42733} Committed: https://chromium.googlesource.com/v8/v8/+/7046c14d354f509e76733babcba80c84e7ee3ea9

Patch Set 1 #

Patch Set 2 : Missing changes #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M src/builtins/builtins-array.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-function.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-string.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 3 chunks +20 lines, -16 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
danno
ptal
3 years, 11 months ago (2017-01-26 20:04:03 UTC) #2
epertoso
lgtm.
3 years, 10 months ago (2017-01-27 10:25:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661483002/40001
3 years, 10 months ago (2017-01-27 11:18:12 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 11:20:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/7046c14d354f509e76733babcba80c84e7e...

Powered by Google App Engine
This is Rietveld 408576698