Extract the mini_installer's entrypoint into its own source file.

Extract the mini_installer's entrypoint into its own source file.

This makes unit tests of other bits of mini_installer.cc possible.

While at it, I also replaced a call to GetModuleHandle with use of
__ImageBase.

BUG=none
R=bcwhite@chromium.org

Review-Url: https://codereview.chromium.org/2661463003
Cr-Commit-Position: refs/heads/master@{#446691}
Committed: https://chromium.googlesource.com/chromium/src/+/321270f5fb1136c33909368fc8d6f538c5277e73

[grt (UTC plus 2), 2017-01-27 11:29:27]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 11:29:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-01-27 11:31:10]

Description was changed from

==========
Extract the mini_installer's entrypoint into its own source file.

This makes unit tests of other bits of mini_installer.cc possible.

BUG=none
R=bcwhite@chromium.org
==========

to

==========
Extract the mini_installer's entrypoint into its own source file.

This makes unit tests of other bits of mini_installer.cc possible.

While at it, I also replaced a call to GetModuleHandle with use of
__ImageBase.

BUG=none
R=bcwhite@chromium.org
==========

[grt (UTC plus 2), 2017-01-27 11:31:29]

Hi Brian. This change is a prereq for adding the unit tests you requested in
https://codereview.chromium.org/2655473002/. PTAL.

[commit-bot: I haz the power, 2017-01-27 12:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 12:31:23]

Dry run: This issue passed the CQ dry run.

[grt (UTC plus 2), 2017-01-27 13:36:12]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 13:36:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 14:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 14:49:23]

Dry run: This issue passed the CQ dry run.

[bcwhite, 2017-01-27 14:59:19]

https://codereview.chromium.org/2661463003/diff/20001/chrome/installer/mini_i...
File chrome/installer/mini_installer/mini_installer_exe_main.cc (right):

https://codereview.chromium.org/2661463003/diff/20001/chrome/installer/mini_i...
chrome/installer/mini_installer/mini_installer_exe_main.cc:40: void* start =
dest;
How about:
  char* ptr = reinterpret_cast<char*>(dest).
  ... use |ptr| instead of |dest| ...
  return dest;

Then you'll have only one reinterpret_cast throughout the code.

[grt (UTC plus 2), 2017-01-27 15:17:45]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 15:17:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2017-01-27 15:18:37]

PTAL

https://codereview.chromium.org/2661463003/diff/20001/chrome/installer/mini_i...
File chrome/installer/mini_installer/mini_installer_exe_main.cc (right):

https://codereview.chromium.org/2661463003/diff/20001/chrome/installer/mini_i...
chrome/installer/mini_installer/mini_installer_exe_main.cc:40: void* start =
dest;
On 2017/01/27 14:59:19, bcwhite wrote:
> How about:
>   char* ptr = reinterpret_cast<char*>(dest).
>   ... use |ptr| instead of |dest| ...
>   return dest;
> 
> Then you'll have only one reinterpret_cast throughout the code.

This code was simply moved from mini_installer.cc into here, so I wasn't
planning on touching it. Anyway, here it is a bit shorter.

[bcwhite, 2017-01-27 15:20:49]

lgtm

[grt (UTC plus 2), 2017-01-27 15:30:27]

The CQ bit was unchecked by grt@chromium.org

[grt (UTC plus 2), 2017-01-27 15:30:27]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2017-01-27 15:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 16:57:16]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485531027564510,
"parent_rev": "847ec9c533fff1957b2bb14e80cc9aa4acead8de", "commit_rev":
"321270f5fb1136c33909368fc8d6f538c5277e73"}

[commit-bot: I haz the power, 2017-01-27 16:57:50]

Description was changed from

==========
Extract the mini_installer's entrypoint into its own source file.

This makes unit tests of other bits of mini_installer.cc possible.

While at it, I also replaced a call to GetModuleHandle with use of
__ImageBase.

BUG=none
R=bcwhite@chromium.org
==========

to

==========
Extract the mini_installer's entrypoint into its own source file.

This makes unit tests of other bits of mini_installer.cc possible.

While at it, I also replaced a call to GetModuleHandle with use of
__ImageBase.

BUG=none
R=bcwhite@chromium.org

Review-Url: https://codereview.chromium.org/2661463003
Cr-Commit-Position: refs/heads/master@{#446691}
Committed:
https://chromium.googlesource.com/chromium/src/+/321270f5fb1136c33909368fc8d6...
==========

[commit-bot: I haz the power, 2017-01-27 16:57:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/321270f5fb1136c33909368fc8d6...