Add a flag to ignoring exportable commits.

Add a flag to ignoring exportable commits.

Review-Url: https://codereview.chromium.org/2661453006
Cr-Commit-Position: refs/heads/master@{#447180}
Committed: https://chromium.googlesource.com/chromium/src/+/81e476a4df0e72d50c328421f887e9111016dd42

[qyearsley, 2017-01-29 00:16:18]

Import wpt@9686434ee249cd7f4441829cdabaecec58905e73

Using wpt-import in Chromium bfd4f2991d4d86e79a275641746cca8679c23b40.

TBR=qyearsley@chromium.org
NOEXPORT=true

[qyearsley, 2017-01-29 00:17:51]

Description was changed from

==========
Add flag to ignore exportable commits (probably don't want to commit).

I'm trying this out temporarily to see whether auto-export still works.
It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason.

BUG=666540
==========

to

==========
Try ignoring exportable commits (do not commit)

I'm trying this out temporarily to see whether auto-export still works.
It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason.
==========

[qyearsley, 2017-01-31 00:14:51]

Description was changed from

==========
Try ignoring exportable commits (do not commit)

I'm trying this out temporarily to see whether auto-export still works.
It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason.
==========

to

==========
Add a flag to ignoring exportable commits.

I was trying this out temporarily to try running the import script.

It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason, but maybe we don't? What do you think?
And maybe it's better to just change combine --ignore-exportable-commits and
--allow-local-commits to a general option called -f/--force?
==========

[qyearsley, 2017-01-31 00:15:09]

Description was changed from

==========
Add a flag to ignoring exportable commits.

I was trying this out temporarily to try running the import script.

It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason, but maybe we don't? What do you think?
And maybe it's better to just change combine --ignore-exportable-commits and
--allow-local-commits to a general option called -f/--force?
==========

to

==========
Add a flag to ignoring exportable commits.
==========

[qyearsley, 2017-01-31 00:15:09]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-01-31 00:15:15]

I was trying this out temporarily to try running the import script.

It's possible that we might want to consider allowing ignoring of
exportable commits later for some reason, but maybe we don't? What do you think?
And maybe it's better to just change combine --ignore-exportable-commits and
--allow-local-commits to a general option called -f/--force?

[jeffcarp, 2017-01-31 00:31:22]

On 2017/01/31 at 00:15:15, qyearsley wrote:
> I was trying this out temporarily to try running the import script.
> 
> It's possible that we might want to consider allowing ignoring of
> exportable commits later for some reason, but maybe we don't? What do you
think? And maybe it's better to just change combine --ignore-exportable-commits
and --allow-local-commits to a general option called -f/--force?

I don't think --force is expressive enough for the two pieces of functionality
it's enabling, so I think the two flags make sense. lgtm

There are a couple more commits that landed in exportable/wpt so we should be
careful not to overwrite them. I'm still trying to harangue gsnedders or jgraham
into force merging the blocking PR. If I can't get it in by EOD today, I'll skip
over that one and export the most recent two.

[qyearsley, 2017-01-31 01:13:04]

On 2017/01/31 at 00:31:22, jeffcarp wrote:
> On 2017/01/31 at 00:15:15, qyearsley wrote:
> > I was trying this out temporarily to try running the import script.
> > 
> > It's possible that we might want to consider allowing ignoring of
> > exportable commits later for some reason, but maybe we don't? What do you
think? And maybe it's better to just change combine --ignore-exportable-commits
and --allow-local-commits to a general option called -f/--force?
> 
> I don't think --force is expressive enough for the two pieces of functionality
it's enabling, so I think the two flags make sense. lgtm
> 
> There are a couple more commits that landed in exportable/wpt so we should be
careful not to overwrite them. 

Makes sense. I agree, we should be careful not to overwrite them.

> I'm still trying to harangue gsnedders or jgraham into force merging the
blocking PR. If I can't get it in by EOD today, I'll skip over that one and
export the most recent two.

In the worst case, if pwnall@'s CL can't be merged for some reason, and we skip
over that one and export the most recent two, then pwnall@'s CL will no longer
be in the queue to upstream, right? In which case, we should then revert the
Chromium-side commit?

[qyearsley, 2017-01-31 01:13:14]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:13:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 03:52:14]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485825194827730,
"parent_rev": "e7b7b06987c3ea395b1cb01ff00027a36911a3ae", "commit_rev":
"81e476a4df0e72d50c328421f887e9111016dd42"}

[commit-bot: I haz the power, 2017-01-31 03:52:50]

Description was changed from

==========
Add a flag to ignoring exportable commits.
==========

to

==========
Add a flag to ignoring exportable commits.

Review-Url: https://codereview.chromium.org/2661453006
Cr-Commit-Position: refs/heads/master@{#447180}
Committed:
https://chromium.googlesource.com/chromium/src/+/81e476a4df0e72d50c328421f887...
==========

[commit-bot: I haz the power, 2017-01-31 03:52:51]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/81e476a4df0e72d50c328421f887...