Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2661453005:
CheckMediaFile: remove utility process ReleaseProcessIfNeeded call (Closed)
|
Created:
3 years, 10 months ago by Noel Gordon Modified:
3 years, 10 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, sammc, tibell Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCheckMediaFile: remove utility process ReleaseProcessIfNeeded call
After https://codereview.chromium.org/2644313002, the utility process
mojo client for CheckMediaFile controls utility process life-time, so
there's no need to call ReleaseProcessIfNeeded in the utility process
anymore, remove it.
TBR=jochen@chromium.org
BUG=680928
Review-Url: https://codereview.chromium.org/2661453005
Cr-Commit-Position: refs/heads/master@{#447692}
Committed: https://chromium.googlesource.com/chromium/src/+/41fd6ea9c3ae787b3133e96cd2e9a845056dbd24
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
noel@chromium.org changed reviewers: + tommycli@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2017/01/30 19:22:51, tommycli wrote: > lgtm I don't think I'm an OWNER though.
Description was changed from ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. BUG=680928 ========== to ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. BUG=680928 ==========
noel@chromium.org changed reviewers: + jochen@chromium.org
On 2017/01/30 19:23:19, tommycli wrote: > On 2017/01/30 19:22:51, tommycli wrote: > > lgtm > > I don't think I'm an OWNER though. +jochen for OWNERS.
Description was changed from ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. BUG=680928 ========== to ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. TBR=jochen@chromium.org BUG=680928 ==========
On 2017/01/30 22:12:05, noel gordon wrote: > On 2017/01/30 19:23:19, tommycli wrote: > > On 2017/01/30 19:22:51, tommycli wrote: > > > lgtm > > > > I don't think I'm an OWNER though. > > +jochen for OWNERS. ^ probably enjoying BlinkOn, talk later.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485999600240630, "parent_rev":
"aeb979c8e155e613bba045ab42f5e615d02ff570", "commit_rev":
"41fd6ea9c3ae787b3133e96cd2e9a845056dbd24"}
Message was sent while issue was closed.
Description was changed from ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. TBR=jochen@chromium.org BUG=680928 ========== to ========== CheckMediaFile: remove utility process ReleaseProcessIfNeeded call After https://codereview.chromium.org/2644313002, the utility process mojo client for CheckMediaFile controls utility process life-time, so there's no need to call ReleaseProcessIfNeeded in the utility process anymore, remove it. TBR=jochen@chromium.org BUG=680928 Review-Url: https://codereview.chromium.org/2661453005 Cr-Commit-Position: refs/heads/master@{#447692} Committed: https://chromium.googlesource.com/chromium/src/+/41fd6ea9c3ae787b3133e96cd2e9... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/41fd6ea9c3ae787b3133e96cd2e9... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
