Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2661363003: PPC/s390: [wasm] Acquire the context for TrapIf from a wasm frame (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [wasm] Acquire the context for TrapIf from a wasm frame Port 87d309dadd062c1c4d279505aa5e36df12026016 Original Commit Message: This is the first step to reduce the size of the out-of-line code of TrapIf. Instead of passing the context to the runtime call as a parameter, we pass Smi::kZero to the runtime call and then get the actual context from the WasmFrame on the stack. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5908 LOG=N Review-Url: https://codereview.chromium.org/2661363003 Cr-Commit-Position: refs/heads/master@{#42858} Committed: https://chromium.googlesource.com/v8/v8/+/c00aeb030086024c380ed7013b1480a4c5d33cfc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-01 15:21:19 UTC) #1
ahaas
On 2017/02/01 at 15:21:19, bjaideep wrote: > ptal lgtm
3 years, 10 months ago (2017-02-01 15:23:47 UTC) #2
john.yan
lgtm
3 years, 10 months ago (2017-02-01 15:37:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661363003/1
3 years, 10 months ago (2017-02-01 15:39:05 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 15:59:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c00aeb030086024c380ed7013b1480a4c5d...

Powered by Google App Engine
This is Rietveld 408576698