Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2661363002: Adding a CORS bypass integration test (Closed)

Created:
3 years, 10 months ago by RyanSturm
Modified:
3 years, 10 months ago
Reviewers:
Robert Ogden, megjablon
CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding a CORS bypass integration test This test verifies that CORS requests are treated with block-once by the data reduction proxy server. BUG=680556 Review-Url: https://codereview.chromium.org/2661363002 Cr-Commit-Position: refs/heads/master@{#447422} Committed: https://chromium.googlesource.com/chromium/src/+/7d56868afb2fd253cfe318d2e39fe591a458f0db

Patch Set 1 #

Total comments: 2

Patch Set 2 : moving to bypass.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M tools/chrome_proxy/webdriver/bypass.py View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
RyanSturm
megjablon, robertogden: PTAL, thanks
3 years, 10 months ago (2017-01-31 21:32:46 UTC) #2
Robert Ogden
lgtm
3 years, 10 months ago (2017-01-31 22:10:26 UTC) #3
megjablon
https://codereview.chromium.org/2661363002/diff/1/tools/chrome_proxy/webdriver/cors_bypass.py File tools/chrome_proxy/webdriver/cors_bypass.py (right): https://codereview.chromium.org/2661363002/diff/1/tools/chrome_proxy/webdriver/cors_bypass.py#newcode1 tools/chrome_proxy/webdriver/cors_bypass.py:1: # Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-02-01 00:14:38 UTC) #4
RyanSturm
megjablon: PTAL https://codereview.chromium.org/2661363002/diff/1/tools/chrome_proxy/webdriver/cors_bypass.py File tools/chrome_proxy/webdriver/cors_bypass.py (right): https://codereview.chromium.org/2661363002/diff/1/tools/chrome_proxy/webdriver/cors_bypass.py#newcode1 tools/chrome_proxy/webdriver/cors_bypass.py:1: # Copyright 2017 The Chromium Authors. All ...
3 years, 10 months ago (2017-02-01 01:45:42 UTC) #6
megjablon
lgtm
3 years, 10 months ago (2017-02-01 01:57:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661363002/20001
3 years, 10 months ago (2017-02-01 02:01:58 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 02:36:33 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d56868afb2fd253cfe318d2e39f...

Powered by Google App Engine
This is Rietveld 408576698