Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: net/http/http_cache.cc

Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider (Closed)
Patch Set: Address ssid comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache.cc
diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc
index b02ddf02adf0a12669426d13131ce0e33839fe58..a59267db3c776515afc267abb209ccffaa0f5054 100644
--- a/net/http/http_cache.cc
+++ b/net/http/http_cache.cc
@@ -481,6 +481,13 @@ HttpCache::SetHttpNetworkTransactionFactoryForTesting(
return old_network_layer;
}
+void HttpCache::DumpMemoryStats(base::trace_event::ProcessMemoryDump* pmd,
+ const std::string& parent_absolute_name) const {
+ if (disk_cache_)
+ disk_cache_->DumpMemoryStats(pmd, parent_absolute_name);
+ // TODO(xunjieli): Track other member allocations.
ssid 2017/02/01 02:45:48 I think TODOs are generally followed by bug number
xunjieli 2017/02/01 14:55:18 Done. Removed the TODO and added tracking for othe
+}
+
//-----------------------------------------------------------------------------
int HttpCache::CreateBackend(disk_cache::Backend** backend,

Powered by Google App Engine
This is Rietveld 408576698