Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by xunjieli
Modified:
2 days, 2 hours ago
Reviewers:
jkarlin, ssid, DmitrySkiba
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track SimpleCache memory usage in net/ MemoryDumpProvider This CL includes SimpleCache in net/ MemoryDumpProvider. BlockFile and In-memory cache will be implemented in a follow-up. BUG=669108

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address ssid comments #

Total comments: 4

Patch Set 3 : Attempt 2. Make estimate cover more #

Patch Set 4 : fix test compile #

Patch Set 5 : self #

Total comments: 2

Patch Set 6 : self review #

Total comments: 9

Patch Set 7 : Pure rebase before addressing comments #

Patch Set 8 : Address comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -0 lines) Patch
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 4 5 6 7 5 chunks +7 lines, -0 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/disk_cache/disk_cache.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 1 2 3 4 5 6 7 3 chunks +16 lines, -0 lines 1 comment Download
M net/disk_cache/simple/simple_entry_impl.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 1 2 3 4 5 6 7 3 chunks +14 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_index.h View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_index.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_cache.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M net/http/http_cache.cc View 1 2 3 4 5 6 7 4 chunks +30 lines, -0 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 4 5 6 7 2 chunks +39 lines, -0 lines 0 comments Download
M net/http/mock_http_cache.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M net/http/mock_http_cache.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M net/url_request/url_request_context.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
Trybot results: Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 41 (24 generated)
xunjieli
Gavin and Sid: PTAL. Thanks!
2 weeks, 5 days ago (2017-01-31 20:49:09 UTC) #4
ssid
My main question here is do we have stats about how much memory other parts ...
2 weeks, 5 days ago (2017-01-31 22:24:20 UTC) #7
xunjieli
> My main question here is do we have stats about how much memory other ...
2 weeks, 5 days ago (2017-02-01 01:15:52 UTC) #8
ssid
On 2017/02/01 01:15:52, xunjieli wrote: > > My main question here is do we have ...
2 weeks, 4 days ago (2017-02-01 02:45:48 UTC) #9
pasko
On 2017/02/01 01:15:52, xunjieli wrote: > > My main question here is do we have ...
2 weeks, 4 days ago (2017-02-01 05:39:40 UTC) #10
xunjieli
My method is simply open a couple of tabs (with a reused profile) wait for ...
2 weeks, 4 days ago (2017-02-01 14:55:18 UTC) #12
ssid
lgtm thanks! https://codereview.chromium.org/2661333002/diff/80001/net/http/http_cache.cc File net/http/http_cache.cc (right): https://codereview.chromium.org/2661333002/diff/80001/net/http/http_cache.cc#newcode128 net/http/http_cache.cc:128: base::trace_event::EstimateMemoryUsage(writer) + Do we need to measure ...
2 weeks, 3 days ago (2017-02-02 19:30:01 UTC) #24
xunjieli
jkarlin@: PTAL at content/browser/cache_storage/cache_storage_cache_unittest.cc Gavin: a friendly ping! Thanks. https://codereview.chromium.org/2661333002/diff/80001/net/http/http_cache.cc File net/http/http_cache.cc (right): https://codereview.chromium.org/2661333002/diff/80001/net/http/http_cache.cc#newcode128 net/http/http_cache.cc:128: ...
2 weeks, 2 days ago (2017-02-03 17:30:27 UTC) #26
jkarlin
cache_storage/ lgtm
2 weeks, 2 days ago (2017-02-03 17:46:13 UTC) #27
pasko
On 2017/02/01 14:55:18, xunjieli wrote: > My method is simply open a couple of tabs ...
2 weeks, 2 days ago (2017-02-03 22:39:16 UTC) #32
xunjieli
On 2017/02/03 22:39:16, pasko wrote: > On 2017/02/01 14:55:18, xunjieli wrote: > > My method ...
2 weeks, 2 days ago (2017-02-03 22:44:40 UTC) #33
jkarlin
Removing gavinp@ as he is OOO for awhile. I'll take a look at net/ as ...
2 days, 9 hours ago (2017-02-17 16:05:31 UTC) #35
jkarlin
Exciting! https://codereview.chromium.org/2661333002/diff/100001/net/disk_cache/simple/simple_backend_impl.cc File net/disk_cache/simple/simple_backend_impl.cc (right): https://codereview.chromium.org/2661333002/diff/100001/net/disk_cache/simple/simple_backend_impl.cc#newcode558 net/disk_cache/simple/simple_backend_impl.cc:558: base::trace_event::EstimateMemoryUsage(active_entries_); Too bad we don't support tracing closures, ...
2 days, 8 hours ago (2017-02-17 17:43:06 UTC) #36
jkarlin
https://codereview.chromium.org/2661333002/diff/100001/net/http/http_cache.cc File net/http/http_cache.cc (right): https://codereview.chromium.org/2661333002/diff/100001/net/http/http_cache.cc#newcode129 net/http/http_cache.cc:129: base::trace_event::EstimateMemoryUsage(pending_queue); On 2017/02/17 17:43:06, jkarlin wrote: > + disk_entry ...
2 days, 7 hours ago (2017-02-17 18:03:43 UTC) #37
jkarlin
https://codereview.chromium.org/2661333002/diff/100001/net/http/http_cache.cc File net/http/http_cache.cc (right): https://codereview.chromium.org/2661333002/diff/100001/net/http/http_cache.cc#newcode113 net/http/http_cache.cc:113: return base::trace_event::EstimateMemoryUsage(readers) + You'll need to EMU HttpCache::Transaction, which ...
2 days, 7 hours ago (2017-02-17 18:13:08 UTC) #38
xunjieli
Dmitry: Could you take a look at the question below? Thank you. https://codereview.chromium.org/2661333002/diff/140001/net/disk_cache/simple/simple_backend_impl.cc File net/disk_cache/simple/simple_backend_impl.cc ...
2 days, 2 hours ago (2017-02-17 22:59:11 UTC) #40
DmitrySkiba
2 days, 2 hours ago (2017-02-17 23:41:05 UTC) #41
On 2017/02/17 22:59:11, xunjieli wrote:
> Dmitry: Could you take a look at the question below? Thank you.
> 
>
https://codereview.chromium.org/2661333002/diff/140001/net/disk_cache/simple/...
> File net/disk_cache/simple/simple_backend_impl.cc (right):
> 
>
https://codereview.chromium.org/2661333002/diff/140001/net/disk_cache/simple/...
> net/disk_cache/simple/simple_backend_impl.cc:212: DCHECK(false);
> Dmitry: I followed your suggestion, but this doesn't seem to be invoked... Any
> idea what might be missing?
> 
> SimpleBackendImple::EstimateMemoryUsage() does call EMU() on active_entries_
> which is a map of int64 to SimpleEntryImpl*.

OK, I gave you the wrong signature. The right one is

size_t EstimateMemoryUsage(SimpleEntryImpl const* const& entry), i.e. const
reference to a const pointer.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd