net/http/http_cache_transaction.h - Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.h

Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider (Closed)

Patch Set: Address jkarlin@ comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.h

diff --git a/net/http/http_cache_transaction.h b/net/http/http_cache_transaction.h

index 32bb23571f48a0a868288b492a1f55dacf48f9cd..2d249c1eda028c6329ed2edc603bfc2f4064a082 100644

--- a/net/http/http_cache_transaction.h

+++ b/net/http/http_cache_transaction.h

@@ -164,6 +164,9 @@ class HttpCache::Transaction : public HttpTransaction {

int ResumeNetworkStart() override;

void GetConnectionAttempts(ConnectionAttempts* out) const override;

+ // Returns the estimate of dynamically allocated memory in bytes.

+ size_t EstimateMemoryUsage() const;

private:

static const size_t kNumValidationHeaders = 2;

// Helper struct to pair a header name with its value, for