net/disk_cache/memory/mem_backend_impl.cc - Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/memory/mem_backend_impl.cc

Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider (Closed)

Patch Set: Pure rebase before addressing comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/memory/mem_backend_impl.cc

diff --git a/net/disk_cache/memory/mem_backend_impl.cc b/net/disk_cache/memory/mem_backend_impl.cc

index 7ded277b2a6eac201ef6bbac4cf5598cd232587c..3aa103b30a02edb0102eead7d15f94a0c91d504f 100644

--- a/net/disk_cache/memory/mem_backend_impl.cc

+++ b/net/disk_cache/memory/mem_backend_impl.cc

@@ -283,6 +283,11 @@ void MemBackendImpl::OnExternalCacheHit(const std::string& key) {

it->second->UpdateStateOnUse(MemEntryImpl::ENTRY_WAS_NOT_MODIFIED);

}

+size_t MemBackendImpl::EstimateMemoryUsage() const {

+ // TODO(xunjieli): Implement this. crbug.com/669108.

+ return 0;

void MemBackendImpl::EvictIfNeeded() {

if (current_size_ <= max_size_)

return;