Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1770)

Unified Diff: net/disk_cache/simple/simple_backend_impl.h

Issue 2661333002: Track SimpleCache memory usage in net/ MemoryDumpProvider (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_backend_impl.h
diff --git a/net/disk_cache/simple/simple_backend_impl.h b/net/disk_cache/simple/simple_backend_impl.h
index a0b4b9c42820e8b05f6dcd3639e5a534af077424..028060f975d2e483e3b32c4ba899a8833a93c04a 100644
--- a/net/disk_cache/simple/simple_backend_impl.h
+++ b/net/disk_cache/simple/simple_backend_impl.h
@@ -31,6 +31,9 @@
namespace base {
class SingleThreadTaskRunner;
class TaskRunner;
+namespace trace_event {
+class ProcessMemoryDump;
+}
}
namespace disk_cache {
@@ -117,6 +120,8 @@ class NET_EXPORT_PRIVATE SimpleBackendImpl : public Backend,
std::unique_ptr<Iterator> CreateIterator() override;
void GetStats(base::StringPairs* stats) override;
void OnExternalCacheHit(const std::string& key) override;
+ void DumpMemoryStats(base::trace_event::ProcessMemoryDump* pmd,
+ const std::string& parent_absolute_name) const override;
ssid 2017/01/31 22:24:19 Do we have stats about how often we use the blockf
xunjieli 2017/02/01 01:15:52 We are moving towards using SimpleCache everywhere
private:
class SimpleIterator;

Powered by Google App Engine
This is Rietveld 408576698