Reland of Changing URL bar constraints only calls performResize on Hidden <-> Both

Reland of Changing URL bar constraints only calls performResize on Hidden <-> Both (patchset #1 id:1 of https://codereview.chromium.org/2659483003/ )

Reason for revert:
Relanding - the revert didn't improve the regressed metric.

Original issue's description:
> Revert of Changing URL bar constraints only calls performResize on Hidden <-> Both (patchset #1 id:1 of https://codereview.chromium.org/2656633003/ )
> 
> Reason for revert:
> Didn't help on the perf bots. Temporarily reverting along with orignial patch to investigate.
> 
> Original issue's description:
> > Changing URL bar constraints only calls performResize on Hidden <-> Both
> > 
> > With the change to the URL bar not causing a vertical resize on showing/hiding,
> > we keep the layout height sized "as if" the URL bar was always shown. However,
> > for fullscreen scenarios, since the URL bar is locked to a hidden state there's
> > no need to keep it static to the smaller size so we use the full viewport
> > height instead.
> > 
> > This means that when we change the URL bar constraints we may need to change
> > the layout height. In most cases, we can rely on a Resize event being sent to
> > the renderer kicking off the layout size change. The one exception here is from
> > a "Locked Hidden" to "Unlocked" state, or vice-versa. That's because the URL
> > bar's state might not change (it can remain hidden) but the layout size should
> > change.
> > 
> > Note that going from "Locked Hidden" -> "Shown" doesn't have this problem as
> > the URL bar state will change necessarily. Going from "Unlocked" -> "Shown" may
> > or may not change the URL bar state, but it will not change the layout height
> > since we use the "Shown" height for layout height when the URL bar is
> > "Unlocked".
> > 
> > Before this patch, we were overly-aggressive in triggering performResize which
> > caused us to perform extra work as the page went from "Locked Shown" to
> > "Unlocked", as happens when the page is navigated. This caused a minor memory
> > regression.  This patch performs the resize only when needed, on going from
> > "Locked Hidden" to "Unlocked" or vice-versa.
> > 
> > BUG=679546
> > 
> > Review-Url: https://codereview.chromium.org/2656633003
> > Cr-Commit-Position: refs/heads/master@{#445855}
> > Committed: https://chromium.googlesource.com/chromium/src/+/38992dee686ca58d5f1a61d44ef3e534b8c2967c
> 
> TBR=aelias@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=679546
> 
> Review-Url: https://codereview.chromium.org/2659483003
> Cr-Commit-Position: refs/heads/master@{#446362}
> Committed: https://chromium.googlesource.com/chromium/src/+/13876a1d16f4e9a09ffacebcd3b9df0a21a2e55b

TBR=aelias@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=679546
Review-Url: https://codereview.chromium.org/2661313004
Cr-Commit-Position: refs/heads/master@{#447463}
Committed: https://chromium.googlesource.com/chromium/src/+/d8628567e99343c383f08fd1b9f103b7a610c90d

[bokan, 2017-02-01 04:03:33]

The CQ bit was checked by bokan@chromium.org

[bokan, 2017-02-01 04:03:33]

Created Reland of Changing URL bar constraints only calls performResize on
Hidden <-> Both

[commit-bot: I haz the power, 2017-02-01 04:03:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 06:32:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485921813007370, "parent_rev":
"745318217f4a2c0e33a781a66c9eb74026010366", "commit_rev":
"d8628567e99343c383f08fd1b9f103b7a610c90d"}

[commit-bot: I haz the power, 2017-02-01 06:33:42]

Description was changed from

==========
Reland of Changing URL bar constraints only calls performResize on Hidden <->
Both (patchset #1 id:1 of https://codereview.chromium.org/2659483003/ )

Reason for revert:
Relanding - the revert didn't improve the regressed metric.

Original issue's description:
> Revert of Changing URL bar constraints only calls performResize on Hidden <->
Both (patchset #1 id:1 of https://codereview.chromium.org/2656633003/ )
> 
> Reason for revert:
> Didn't help on the perf bots. Temporarily reverting along with orignial patch
to investigate.
> 
> Original issue's description:
> > Changing URL bar constraints only calls performResize on Hidden <-> Both
> > 
> > With the change to the URL bar not causing a vertical resize on
showing/hiding,
> > we keep the layout height sized "as if" the URL bar was always shown.
However,
> > for fullscreen scenarios, since the URL bar is locked to a hidden state
there's
> > no need to keep it static to the smaller size so we use the full viewport
> > height instead.
> > 
> > This means that when we change the URL bar constraints we may need to change
> > the layout height. In most cases, we can rely on a Resize event being sent
to
> > the renderer kicking off the layout size change. The one exception here is
from
> > a "Locked Hidden" to "Unlocked" state, or vice-versa. That's because the URL
> > bar's state might not change (it can remain hidden) but the layout size
should
> > change.
> > 
> > Note that going from "Locked Hidden" -> "Shown" doesn't have this problem as
> > the URL bar state will change necessarily. Going from "Unlocked" -> "Shown"
may
> > or may not change the URL bar state, but it will not change the layout
height
> > since we use the "Shown" height for layout height when the URL bar is
> > "Unlocked".
> > 
> > Before this patch, we were overly-aggressive in triggering performResize
which
> > caused us to perform extra work as the page went from "Locked Shown" to
> > "Unlocked", as happens when the page is navigated. This caused a minor
memory
> > regression.  This patch performs the resize only when needed, on going from
> > "Locked Hidden" to "Unlocked" or vice-versa.
> > 
> > BUG=679546
> > 
> > Review-Url: https://codereview.chromium.org/2656633003
> > Cr-Commit-Position: refs/heads/master@{#445855}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/38992dee686ca58d5f1a61d44ef3...
> 
> TBR=aelias@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=679546
> 
> Review-Url: https://codereview.chromium.org/2659483003
> Cr-Commit-Position: refs/heads/master@{#446362}
> Committed:
https://chromium.googlesource.com/chromium/src/+/13876a1d16f4e9a09ffacebcd3b9...

TBR=aelias@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=679546
==========

to

==========
Reland of Changing URL bar constraints only calls performResize on Hidden <->
Both (patchset #1 id:1 of https://codereview.chromium.org/2659483003/ )

Reason for revert:
Relanding - the revert didn't improve the regressed metric.

Original issue's description:
> Revert of Changing URL bar constraints only calls performResize on Hidden <->
Both (patchset #1 id:1 of https://codereview.chromium.org/2656633003/ )
> 
> Reason for revert:
> Didn't help on the perf bots. Temporarily reverting along with orignial patch
to investigate.
> 
> Original issue's description:
> > Changing URL bar constraints only calls performResize on Hidden <-> Both
> > 
> > With the change to the URL bar not causing a vertical resize on
showing/hiding,
> > we keep the layout height sized "as if" the URL bar was always shown.
However,
> > for fullscreen scenarios, since the URL bar is locked to a hidden state
there's
> > no need to keep it static to the smaller size so we use the full viewport
> > height instead.
> > 
> > This means that when we change the URL bar constraints we may need to change
> > the layout height. In most cases, we can rely on a Resize event being sent
to
> > the renderer kicking off the layout size change. The one exception here is
from
> > a "Locked Hidden" to "Unlocked" state, or vice-versa. That's because the URL
> > bar's state might not change (it can remain hidden) but the layout size
should
> > change.
> > 
> > Note that going from "Locked Hidden" -> "Shown" doesn't have this problem as
> > the URL bar state will change necessarily. Going from "Unlocked" -> "Shown"
may
> > or may not change the URL bar state, but it will not change the layout
height
> > since we use the "Shown" height for layout height when the URL bar is
> > "Unlocked".
> > 
> > Before this patch, we were overly-aggressive in triggering performResize
which
> > caused us to perform extra work as the page went from "Locked Shown" to
> > "Unlocked", as happens when the page is navigated. This caused a minor
memory
> > regression.  This patch performs the resize only when needed, on going from
> > "Locked Hidden" to "Unlocked" or vice-versa.
> > 
> > BUG=679546
> > 
> > Review-Url: https://codereview.chromium.org/2656633003
> > Cr-Commit-Position: refs/heads/master@{#445855}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/38992dee686ca58d5f1a61d44ef3...
> 
> TBR=aelias@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=679546
> 
> Review-Url: https://codereview.chromium.org/2659483003
> Cr-Commit-Position: refs/heads/master@{#446362}
> Committed:
https://chromium.googlesource.com/chromium/src/+/13876a1d16f4e9a09ffacebcd3b9...

TBR=aelias@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=679546

Review-Url: https://codereview.chromium.org/2661313004
Cr-Commit-Position: refs/heads/master@{#447463}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8628567e99343c383f08fd1b9f1...
==========

[commit-bot: I haz the power, 2017-02-01 06:33:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8628567e99343c383f08fd1b9f1...