Improve performance of search geolocation disclosure check.

Improve performance of search geolocation disclosure check.

This check is run for all navigations, but the disclosure is only shown
in a small number of cases. This change reorders the checks to do the
more expensive Android permission check later in the process.

BUG=681663
Review-Url: https://codereview.chromium.org/2661303003
Cr-Commit-Position: refs/heads/master@{#447628}
Committed: https://chromium.googlesource.com/chromium/src/+/c7b66b0e4837e533f8ec3edf9125144e5e3430bd

[benwells, 2017-01-31 20:41:57]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:42:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:22:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:22:05]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-01-31 22:28:53]

benwells@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-02-01 18:04:41]

https://codereview.chromium.org/2661303003/diff/1/chrome/browser/android/sear...
File
chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc
(right):

https://codereview.chromium.org/2661303003/diff/1/chrome/browser/android/sear...
chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.cc:117:
return;
As discussed in person, we may want to move this right to the bottom to avoid
calling it in as many cases as possible :)

[benwells, 2017-02-01 19:24:17]

The CQ bit was checked by benwells@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 19:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:06:49]

Dry run: This issue passed the CQ dry run.

[benwells, 2017-02-01 21:13:49]

All moved and tests all seem to pass...

[raymes, 2017-02-01 22:43:07]

lgtm

[benwells, 2017-02-01 22:46:05]

The CQ bit was checked by benwells@chromium.org

[commit-bot: I haz the power, 2017-02-01 22:46:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 22:51:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485989165928330,
"parent_rev": "d1b7237e603d1993bdeb0eefed98002d433ba31f", "commit_rev":
"c7b66b0e4837e533f8ec3edf9125144e5e3430bd"}

[commit-bot: I haz the power, 2017-02-01 22:52:57]

Description was changed from

==========
Improve performance of search geolocation disclosure check.

This check is run for all navigations, but the disclosure is only shown
in a small number of cases. This change reorders the checks to do the
more expensive Android permission check later in the process.

BUG=681663
==========

to

==========
Improve performance of search geolocation disclosure check.

This check is run for all navigations, but the disclosure is only shown
in a small number of cases. This change reorders the checks to do the
more expensive Android permission check later in the process.

BUG=681663

Review-Url: https://codereview.chromium.org/2661303003
Cr-Commit-Position: refs/heads/master@{#447628}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7b66b0e4837e533f8ec3edf9125...
==========

[commit-bot: I haz the power, 2017-02-01 22:52:58]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7b66b0e4837e533f8ec3edf9125...