Android: Auto-detect output directory in generate_gradle.py

Android: Auto-detect output directory in generate_gradle.py

BUG=none

Review-Url: https://codereview.chromium.org/2661243002
Cr-Commit-Position: refs/heads/master@{#447328}
Committed: https://chromium.googlesource.com/chromium/src/+/3cfd71affd2ece0c60efa1c1f98481ffae83d365

[agrieve, 2017-01-31 15:30:32]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2017-01-31 15:30:44]

Description was changed from

==========
Android: Auto-detect output directory in generate_gradle.py

BUG=none
==========

to

==========
Android: Auto-detect output directory in generate_gradle.py

BUG=none
==========

[agrieve, 2017-01-31 15:30:44]

agrieve@chromium.org changed reviewers:
+ wnwen@chromium.org

[commit-bot: I haz the power, 2017-01-31 15:30:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-01-31 15:30:48]

On 2017/01/31 15:30:44, agrieve (mostly OOO till 31st) wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:wnwen@chromium.org

[Peter Wen, 2017-01-31 15:40:15]

lgtm

Although it raises an exception if neither environment variables are found.

Traceback (most recent call last):
  File "build/android/gradle/generate_gradle.py", line 601, in <module>
    main()
  File "build/android/gradle/generate_gradle.py", line 517, in main
    constants.CheckOutputDirectory()
  File "build/android/gradle/../pylib/constants/__init__.py", line 211, in
CheckOutputDirectory
    raise Exception('Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR '
Exception: Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR has been set

[agrieve, 2017-01-31 15:54:46]

On 2017/01/31 15:40:15, Peter Wen wrote:
> lgtm
> 
> Although it raises an exception if neither environment variables are found.
> 
> Traceback (most recent call last):
>   File "build/android/gradle/generate_gradle.py", line 601, in <module>
>     main()
>   File "build/android/gradle/generate_gradle.py", line 517, in main
>     constants.CheckOutputDirectory()
>   File "build/android/gradle/../pylib/constants/__init__.py", line 211, in
> CheckOutputDirectory
>     raise Exception('Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR '
> Exception: Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR has been set

Ah, yeah, that's quite confusing as well I agree. That happens with many of our
scripts though, so we should address it separately. Still, better an exception
than it building a project where you weren't expecting it. Or in my case:

2017-01-31 06:45:15 -0500 ninja: Entering directory
`/usr/local/google/home/agrieve/ssd/git/clankium1/src/out/Debug'
2017-01-31 06:45:15 -0500 ninja: fatal: chdir to
'/usr/local/google/home/agrieve/ssd/git/clankium1/src/out/Debug' - No such file
or directory
2017-01-31 06:45:15 -0500 Traceback (most recent call last):
2017-01-31 06:45:15 -0500   File
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
line 600, in <module>
2017-01-31 06:45:15 -0500     main()
2017-01-31 06:45:15 -0500   File
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
line 542, in main
2017-01-31 06:45:15 -0500     _RunNinja(output_dir, [e.NinjaBuildConfigTarget()
for e in main_entries])
2017-01-31 06:45:15 -0500   File
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
line 99, in _RunNinja
2017-01-31 06:45:15 -0500     subprocess.check_call(cmd)
2017-01-31 06:45:15 -0500   File "/usr/lib/python2.7/subprocess.py", line 540,
in check_call
2017-01-31 06:45:15 -0500     raise CalledProcessError(retcode, cmd)

[Peter Wen, 2017-01-31 15:56:05]

On 2017/01/31 15:54:46, agrieve (mostly OOO till 31st) wrote:
> On 2017/01/31 15:40:15, Peter Wen wrote:
> > lgtm
> > 
> > Although it raises an exception if neither environment variables are found.
> > 
> > Traceback (most recent call last):
> >   File "build/android/gradle/generate_gradle.py", line 601, in <module>
> >     main()
> >   File "build/android/gradle/generate_gradle.py", line 517, in main
> >     constants.CheckOutputDirectory()
> >   File "build/android/gradle/../pylib/constants/__init__.py", line 211, in
> > CheckOutputDirectory
> >     raise Exception('Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR '
> > Exception: Neither CHROMIUM_OUTPUT_DIR nor CHROMIUM_OUT_DIR has been set
> 
> Ah, yeah, that's quite confusing as well I agree. That happens with many of
our
> scripts though, so we should address it separately. Still, better an exception
> than it building a project where you weren't expecting it. Or in my case:
> 
> 2017-01-31 06:45:15 -0500 ninja: Entering directory
> `/usr/local/google/home/agrieve/ssd/git/clankium1/src/out/Debug'
> 2017-01-31 06:45:15 -0500 ninja: fatal: chdir to
> '/usr/local/google/home/agrieve/ssd/git/clankium1/src/out/Debug' - No such
file
> or directory
> 2017-01-31 06:45:15 -0500 Traceback (most recent call last):
> 2017-01-31 06:45:15 -0500   File
>
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
> line 600, in <module>
> 2017-01-31 06:45:15 -0500     main()
> 2017-01-31 06:45:15 -0500   File
>
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
> line 542, in main
> 2017-01-31 06:45:15 -0500     _RunNinja(output_dir,
[e.NinjaBuildConfigTarget()
> for e in main_entries])
> 2017-01-31 06:45:15 -0500   File
>
"/usr/local/google/home/agrieve/ssd/git/clankium1/src/build/android/gradle/generate_gradle.py",
> line 99, in _RunNinja
> 2017-01-31 06:45:15 -0500     subprocess.check_call(cmd)
> 2017-01-31 06:45:15 -0500   File "/usr/lib/python2.7/subprocess.py", line 540,
> in check_call
> 2017-01-31 06:45:15 -0500     raise CalledProcessError(retcode, cmd)

True, easier for users to set up their environment variables the way they like
than override the default parameter all the time.

[commit-bot: I haz the power, 2017-01-31 17:12:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 17:12:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[agrieve, 2017-01-31 20:18:23]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:19:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:05:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485893903932360, "parent_rev":
"57e26aa79dd0a3568b9e9e6cb51d3e154dc7bee0", "commit_rev":
"3cfd71affd2ece0c60efa1c1f98481ffae83d365"}

[commit-bot: I haz the power, 2017-01-31 21:05:37]

Description was changed from

==========
Android: Auto-detect output directory in generate_gradle.py

BUG=none
==========

to

==========
Android: Auto-detect output directory in generate_gradle.py

BUG=none

Review-Url: https://codereview.chromium.org/2661243002
Cr-Commit-Position: refs/heads/master@{#447328}
Committed:
https://chromium.googlesource.com/chromium/src/+/3cfd71affd2ece0c60efa1c1f984...
==========

[commit-bot: I haz the power, 2017-01-31 21:05:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3cfd71affd2ece0c60efa1c1f984...