Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2661233002: [parser] Add more tests for preparser variable tracking. (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Add more tests for preparser variable tracking. BUG=v8:5501 Review-Url: https://codereview.chromium.org/2661233002 Cr-Commit-Position: refs/heads/master@{#42819} Committed: https://chromium.googlesource.com/v8/v8/+/c41f5f2de68d4cc330ed9a0034f0f1573e4aab49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
marja
ptal
3 years, 10 months ago (2017-01-31 15:38:32 UTC) #2
neis
lgtm
3 years, 10 months ago (2017-01-31 15:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661233002/1
3 years, 10 months ago (2017-01-31 15:44:27 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 16:10:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c41f5f2de68d4cc330ed9a0034f0f1573e4...

Powered by Google App Engine
This is Rietveld 408576698