[ESnext] Disallow using new with import()

[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression. Adds a new error msg as well.

BUG=v8:5785
Review-Url: https://codereview.chromium.org/2661113002
Cr-Commit-Position: refs/heads/master@{#42827}
Committed: https://chromium.googlesource.com/v8/v8/+/d08fd93ba6d9ffeba21c76601f75c5ffa4eb9d38

[gsathya, 2017-01-31 02:20:00]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 02:20:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-31 02:20:28]

Description was changed from

==========
[import] Disallow using new with import()

BUG=v8:5785
==========

to

==========
[import] Disallow using new with import()

BUG=v8:5785
==========

[gsathya, 2017-01-31 02:20:28]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org, neis@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:49:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 02:49:54]

Dry run: This issue passed the CQ dry run.

[neis, 2017-01-31 11:23:11]

lgtm if you make the description clearer (also I'd guess most people have no
idea what [import] means, so better stick to [ESnext] or [modules]).

[gsathya, 2017-01-31 18:28:28]

Description was changed from

==========
[import] Disallow using new with import()

BUG=v8:5785
==========

to

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression.

BUG=v8:5785
==========

[gsathya, 2017-01-31 18:28:28]

Description was changed from

==========
[import] Disallow using new with import()

BUG=v8:5785
==========

to

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression.

BUG=v8:5785
==========

[gsathya, 2017-01-31 20:54:25]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:54:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 20:58:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:58:07]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33748)

[gsathya, 2017-01-31 21:02:48]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 21:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:29:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:29:23]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-01-31 21:31:30]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-01-31 21:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2661113002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-31 21:31:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 21:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 21:35:16]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33752)

[gsathya, 2017-01-31 21:38:34]

On 2017/01/31 21:35:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33752)

i guess i need a lgtm from adam

[adamk, 2017-01-31 22:12:57]

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:3326: MessageTemplate::kUnexpectedToken,
Please add a specialized error message for this case.

[gsathya, 2017-01-31 22:23:55]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:24:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-31 22:24:09]

Description was changed from

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression.

BUG=v8:5785
==========

to

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression. Adds a new error msg as
well.

BUG=v8:5785
==========

[gsathya, 2017-01-31 22:25:42]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:25:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-01-31 22:27:32]

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:3326: MessageTemplate::kUnexpectedToken,
On 2017/01/31 22:12:56, adamk wrote:
> Please add a specialized error message for this case.

Updated. But why? We don't have one for "new super()".

[adamk, 2017-01-31 22:32:16]

lgtm

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base.h
File src/parsing/parser-base.h (right):

https://codereview.chromium.org/2661113002/diff/20001/src/parsing/parser-base...
src/parsing/parser-base.h:3326: MessageTemplate::kUnexpectedToken,
On 2017/01/31 22:27:31, gsathya wrote:
> On 2017/01/31 22:12:56, adamk wrote:
> > Please add a specialized error message for this case.
> 
> Updated. But why? We don't have one for "new super()".

Just because it's easy to give a better error here. We have some good error
messages and some bad ones, I don't see why new error messages shouldn't be as
good as we can make them, especially if it's trivial.

[commit-bot: I haz the power, 2017-01-31 22:43:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 22:43:06]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[gsathya, 2017-01-31 22:53:44]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:53:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:22:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:22:33]

Dry run: This issue passed the CQ dry run.

[gsathya, 2017-02-01 00:30:23]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-02-01 00:30:23]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2661113002/#ps80001
(title: "update goldens")

[commit-bot: I haz the power, 2017-02-01 00:30:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:32:35]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485909023299260,
"parent_rev": "ea96fdec68d5c536f2e9d2deb3bbe02811210bd1", "commit_rev":
"d08fd93ba6d9ffeba21c76601f75c5ffa4eb9d38"}

[commit-bot: I haz the power, 2017-02-01 00:32:43]

Description was changed from

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression. Adds a new error msg as
well.

BUG=v8:5785
==========

to

==========
[ESnext] Disallow using new with import()

Throw a syntax error on "new import(1)"  expression. Adds a new error msg as
well.

BUG=v8:5785

Review-Url: https://codereview.chromium.org/2661113002
Cr-Commit-Position: refs/heads/master@{#42827}
Committed:
https://chromium.googlesource.com/v8/v8/+/d08fd93ba6d9ffeba21c76601f75c5ffa4e...
==========

[commit-bot: I haz the power, 2017-02-01 00:32:44]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/d08fd93ba6d9ffeba21c76601f75c5ffa4e...