android: Remove wrong assert in disableSharedRelros

android: Remove wrong assert in disableSharedRelros

This assert can be hit in practice:
In child process, if sharing relro section fails, child will try to load
the library again with relro disabled. But at that point,
prepareLibraryLoad has already been called.

So just remove the assert.

BUG=680775
Review-Url: https://codereview.chromium.org/2661073002
Cr-Commit-Position: refs/heads/master@{#447520}
Committed: https://chromium.googlesource.com/chromium/src/+/9d06c9d1dbba894cb8cc79230675d3fefd189296

[boliu, 2017-01-31 00:03:57]

Description was changed from

==========
android: Remove wrong assert in disableSharedRelros

This assert can be hit in practice:
In child process, if sharing relro section fails, child will try to load
the library again with relro disabled. But at that point,
prepareLibraryLoad has already been called.

BUG=680775
==========

to

==========
android: Remove wrong assert in disableSharedRelros

This assert can be hit in practice:
In child process, if sharing relro section fails, child will try to load
the library again with relro disabled. But at that point,
prepareLibraryLoad has already been called.

So just remove the assert.

BUG=680775
==========

[boliu, 2017-01-31 00:04:07]

boliu@chromium.org changed reviewers:
+ nyquist@chromium.org

[boliu, 2017-01-31 00:04:08]

ptal

[boliu, 2017-02-01 00:01:38]

ping!

[nyquist, 2017-02-01 07:07:22]

lgtm

[boliu, 2017-02-01 14:21:24]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-02-01 14:21:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 15:57:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485958884157080, "parent_rev":
"2d63197476a9e1146568d1b2747df290049a5c07", "commit_rev":
"9d06c9d1dbba894cb8cc79230675d3fefd189296"}

[commit-bot: I haz the power, 2017-02-01 15:58:36]

Description was changed from

==========
android: Remove wrong assert in disableSharedRelros

This assert can be hit in practice:
In child process, if sharing relro section fails, child will try to load
the library again with relro disabled. But at that point,
prepareLibraryLoad has already been called.

So just remove the assert.

BUG=680775
==========

to

==========
android: Remove wrong assert in disableSharedRelros

This assert can be hit in practice:
In child process, if sharing relro section fails, child will try to load
the library again with relro disabled. But at that point,
prepareLibraryLoad has already been called.

So just remove the assert.

BUG=680775

Review-Url: https://codereview.chromium.org/2661073002
Cr-Commit-Position: refs/heads/master@{#447520}
Committed:
https://chromium.googlesource.com/chromium/src/+/9d06c9d1dbba894cb8cc79230675...
==========

[commit-bot: I haz the power, 2017-02-01 15:58:37]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d06c9d1dbba894cb8cc79230675...