[Cleanup] Clarify a histogram macro comment.

[Cleanup] Clarify a histogram macro comment.

BUG=none
TEST=none
R=rkaplow@chormium.org

Review-Url: https://codereview.chromium.org/2661023008
Cr-Commit-Position: refs/heads/master@{#452434}
Committed: https://chromium.googlesource.com/chromium/src/+/109a96913ee46eb93872ebc1333ad370894c39a6

[Ilya Sherman, 2017-02-22 20:15:27]

Description was changed from

==========
[Cleanup] Clarify a histogram macro comment.

BUG=none
TEST=none
R=rkaplow@chormium.org
==========

to

==========
[Cleanup] Clarify a histogram macro comment.

BUG=none
TEST=none
R=rkaplow@chormium.org
==========

[Ilya Sherman, 2017-02-22 20:15:27]

isherman@chromium.org changed reviewers:
+ rkaplow@chromium.org
- rkaplow@chormium.org

[rkaplow, 2017-02-22 20:24:21]

https://codereview.chromium.org/2661023008/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros_internal.h (right):

https://codereview.chromium.org/2661023008/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros_internal.h:99: // For an enumeration with N items,
recording values in the range [0, N + 1),
i think this should be [0, N], since I think you're not counting the 0th item?

ex N = 3, so N items

[0,1] [1,2] [2,3] [3,inf]
N+1 buckets

and then in the latter comment it should be
.., [N - 1, N)

and similar edits later, the maximal value is N-1

[Ilya Sherman, 2017-02-22 23:31:07]

https://codereview.chromium.org/2661023008/diff/1/base/metrics/histogram_macr...
File base/metrics/histogram_macros_internal.h (right):

https://codereview.chromium.org/2661023008/diff/1/base/metrics/histogram_macr...
base/metrics/histogram_macros_internal.h:99: // For an enumeration with N items,
recording values in the range [0, N + 1),
On 2017/02/22 20:24:20, rkaplow (slow) wrote:
> i think this should be [0, N], since I think you're not counting the 0th item?
> 
> ex N = 3, so N items
> 
> [0,1] [1,2] [2,3] [3,inf]
> N+1 buckets
> 
> and then in the latter comment it should be
> .., [N - 1, N)
> 
> and similar edits later, the maximal value is N-1 

D'oh!  Off by one!  Good catch, Rob.  Done.

[rkaplow, 2017-02-23 00:14:03]

lgtm

[Ilya Sherman, 2017-02-23 07:48:50]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-02-23 07:49:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 08:49:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487836130887440,
"parent_rev": "2a5e317098b0b38a990b24743eb072093c7ef634", "commit_rev":
"109a96913ee46eb93872ebc1333ad370894c39a6"}

[commit-bot: I haz the power, 2017-02-23 08:50:34]

Description was changed from

==========
[Cleanup] Clarify a histogram macro comment.

BUG=none
TEST=none
R=rkaplow@chormium.org
==========

to

==========
[Cleanup] Clarify a histogram macro comment.

BUG=none
TEST=none
R=rkaplow@chormium.org

Review-Url: https://codereview.chromium.org/2661023008
Cr-Commit-Position: refs/heads/master@{#452434}
Committed:
https://chromium.googlesource.com/chromium/src/+/109a96913ee46eb93872ebc1333a...
==========

[commit-bot: I haz the power, 2017-02-23 08:50:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/109a96913ee46eb93872ebc1333a...