Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2661023007: MD Settings: CrOS: Internet: IPConfig: Set correct property (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: CrOS: Internet: IPConfig: Set correct property This fixess a regression introduced here: https://codereview.chromium.org/2300783002 BUG=687278 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2661023007 Cr-Commit-Position: refs/heads/master@{#447590} Committed: https://chromium.googlesource.com/chromium/src/+/12a5a0b5a474a24c6943aef3686d91199a2e2b58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/internet_page/network_ip_config.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 10 months ago (2017-02-01 01:56:08 UTC) #3
michaelpg
lgtm
3 years, 10 months ago (2017-02-01 02:58:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661023007/1
3 years, 10 months ago (2017-02-01 03:04:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/7024)
3 years, 10 months ago (2017-02-01 03:12:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661023007/1
3 years, 10 months ago (2017-02-01 18:35:31 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:14:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/12a5a0b5a474a24c6943aef3686d...

Powered by Google App Engine
This is Rietveld 408576698