Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2661023006: Remove unused references to NativeTheme in TrayPopupItemStyle. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson, bruthig
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused references to NativeTheme in TrayPopupItemStyle. BUG=665891 Review-Url: https://codereview.chromium.org/2661023006 Cr-Commit-Position: refs/heads/master@{#447917} Committed: https://chromium.googlesource.com/chromium/src/+/99ef2a3d77b1586046212f8773dec294ac6db129

Patch Set 1 #

Patch Set 2 : inline/share more #

Total comments: 12

Patch Set 3 : tdanderson review #

Patch Set 4 : slight improvement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -348 lines) Patch
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 8 chunks +17 lines, -40 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 3 chunks +8 lines, -23 lines 0 comments Download
M ash/common/system/chromeos/network/network_list_md.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_vpn.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/vpn_list_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/palette/palette_tray.cc View 3 chunks +6 lines, -17 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_view.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/power/power_status_view.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/screen_security/screen_tray_item.cc View 2 chunks +2 lines, -13 lines 0 comments Download
M ash/common/system/chromeos/tray_caps_lock.cc View 6 chunks +15 lines, -32 lines 0 comments Download
M ash/common/system/chromeos/tray_tracing.cc View 1 2 3 chunks +13 lines, -29 lines 0 comments Download
M ash/common/system/date/date_view.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/common/system/date/date_view.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M ash/common/system/tray/hover_highlight_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_details_view.h View 3 chunks +0 lines, -11 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 4 chunks +5 lines, -20 lines 0 comments Download
M ash/common/system/tray/tray_item_more.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/tray_popup_item_style.h View 5 chunks +0 lines, -38 lines 0 comments Download
M ash/common/system/tray/tray_popup_item_style.cc View 1 2 3 1 chunk +19 lines, -57 lines 0 comments Download
M ash/common/system/update/tray_update.cc View 4 chunks +6 lines, -22 lines 0 comments Download

Messages

Total messages: 27 (17 generated)
Evan Stade
3 years, 10 months ago (2017-02-01 01:48:08 UTC) #5
bruthig
Drive by... https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc#newcode127 ash/common/system/chromeos/network/vpn_list_view.cc:127: const SkColor image_color = GetNativeTheme()->GetSystemColor( I didn't ...
3 years, 10 months ago (2017-02-01 22:50:08 UTC) #10
tdanderson
LGTM with some comments below plus Ben's comment addressed. https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h File ash/common/system/chromeos/power/power_status_view.h (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h#newcode39 ash/common/system/chromeos/power/power_status_view.h:39: ...
3 years, 10 months ago (2017-02-01 23:01:52 UTC) #11
Evan Stade
https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc#newcode127 ash/common/system/chromeos/network/vpn_list_view.cc:127: const SkColor image_color = GetNativeTheme()->GetSystemColor( On 2017/02/01 22:50:08, bruthig ...
3 years, 10 months ago (2017-02-01 23:17:46 UTC) #12
bruthig
https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc File ash/common/system/chromeos/network/vpn_list_view.cc (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/network/vpn_list_view.cc#newcode127 ash/common/system/chromeos/network/vpn_list_view.cc:127: const SkColor image_color = GetNativeTheme()->GetSystemColor( On 2017/02/01 23:17:46, Evan ...
3 years, 10 months ago (2017-02-01 23:31:02 UTC) #13
Evan Stade
https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h File ash/common/system/chromeos/power/power_status_view.h (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h#newcode39 ash/common/system/chromeos/power/power_status_view.h:39: void UpdateStyle(); On 2017/02/01 23:01:52, tdanderson wrote: > I ...
3 years, 10 months ago (2017-02-02 22:49:53 UTC) #14
Evan Stade
https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/tray/tray_popup_item_style.cc File ash/common/system/tray/tray_popup_item_style.cc (right): https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/tray/tray_popup_item_style.cc#newcode50 ash/common/system/tray/tray_popup_item_style.cc:50: return SkColorSetA(kBaseTextColor, 0xDE); On 2017/02/02 22:49:53, Evan Stade wrote: ...
3 years, 10 months ago (2017-02-02 22:52:09 UTC) #17
tdanderson
On 2017/02/02 22:49:53, Evan Stade wrote: > https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h > File ash/common/system/chromeos/power/power_status_view.h (right): > > https://codereview.chromium.org/2661023006/diff/20001/ash/common/system/chromeos/power/power_status_view.h#newcode39 ...
3 years, 10 months ago (2017-02-02 22:56:25 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661023006/60001
3 years, 10 months ago (2017-02-03 00:40:52 UTC) #24
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 03:58:22 UTC) #27
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/99ef2a3d77b1586046212f8773de...

Powered by Google App Engine
This is Rietveld 408576698