Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2661003004: Adds framework classes for ALL remaining parseSingleValue Ribbon APIs. (Closed)

Created:
3 years, 10 months ago by aazzam
Modified:
3 years, 10 months ago
Reviewers:
sashab, shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, jfernandez, Manuel Rego, rwlbuis, svillar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds framework classes for ALL remaining parseSingleValue Ribbon APIs. A part of Project Ribbon, separating the parsing logic for CSS properties from the parser into an API. This patch adds the .cpp files for the remaining unimplemented properties, however does not implement any API methods in these files. The api_class flag was added to each of the properties in CSSProperties.json5 which indicates that the corresponding .h files are be generated. This is prework for implementing parseSingleValue in each of these files in follow up patches. This prevents conflicts in the BUILD.gn file when these APIs later. BUG=668012 Review-Url: https://codereview.chromium.org/2661003004 Cr-Commit-Position: refs/heads/master@{#448178} Committed: https://chromium.googlesource.com/chromium/src/+/e6865cb7255a77d837430d6f570ba4e87d143a38

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -5 lines) Patch
M third_party/WebKit/Source/build/scripts/make_css_property_apis.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 5 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 49 chunks +71 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 5 chunks +19 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIAlignOrJustifyContent.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageOutset.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageRepeat.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageSlice.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderImageWidth.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderWidth.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterIncrement.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPICounterReset.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFilter.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIFlexGrowOrShrink.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridAutoLine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridLine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateAreas.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridTemplateLine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIMarker.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetDistance.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetRotate.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIPerspective.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIShadow.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIStrokeOrLength.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecoration.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPITextDecorationLine.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderImage.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderSpacing.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBorderWidth.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitBoxFlex.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitLogicalWidthOrHeight.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitMaskRepeat.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginX.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWebkitOriginY.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/properties/CSSPropertyAPIWidthOrHeight.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyDescriptor.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
aazzam
ptal sasha and darren! :)
3 years, 10 months ago (2017-01-31 23:00:56 UTC) #3
shend
On 2017/01/31 at 23:00:56, aazzam wrote: > ptal sasha and darren! :) lgtm CL desc. ...
3 years, 10 months ago (2017-01-31 23:14:18 UTC) #4
sashab
LGTM with darrens suggestion, I like the "ALL" part of the title too, makes it ...
3 years, 10 months ago (2017-01-31 23:16:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661003004/20001
3 years, 10 months ago (2017-02-05 05:02:06 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 05:35:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e6865cb7255a77d837430d6f570b...

Powered by Google App Engine
This is Rietveld 408576698