Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2660953002: [Remote suggestions] Clean up variation params in the request throttler (Closed)

Created:
3 years, 10 months ago by jkrcal
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remote suggestions] Clean up variation params in the request throttler This CL associates the variation parameters in the request throttler to the NTPArticleSuggestions feature. This will streamline the configs. BUG=686778 Review-Url: https://codereview.chromium.org/2660953002 Cr-Commit-Position: refs/heads/master@{#447212} Committed: https://chromium.googlesource.com/chromium/src/+/f74de5a3c99c463ae51c090d53770fb52f4ebeb4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M components/ntp_snippets/remote/request_throttler.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jkrcal
Part 3, please!
3 years, 10 months ago (2017-01-30 17:29:50 UTC) #2
Marc Treib
LGTM! This one will actually require updates to the server-side configs; please land them soon ...
3 years, 10 months ago (2017-01-31 09:05:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660953002/1
3 years, 10 months ago (2017-01-31 09:19:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 09:23:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f74de5a3c99c463ae51c090d5377...

Powered by Google App Engine
This is Rietveld 408576698