Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2660893002: DevTools: migrate ResourcesPanel icons over to UI.Icon (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate ResourcesPanel icons over to UI.Icon This patch migrates ResourcesPanel over to the UI.Icon. This CL is a bit longer then usual migration CL's because a few thigns had to happen simultaneously: - a new spritesheet is created for the resourceGlyphs - the treeElement.createIcon() method is no longer needed - the rest of ResourcesPanel is migrated over to the UI.Icon BUG=669323 R=dgozman Review-Url: https://codereview.chromium.org/2660893002 Cr-Commit-Position: refs/heads/master@{#447191} Committed: https://chromium.googlesource.com/chromium/src/+/4b1dc85cf4ee7711aaf07585ec51249e77cfbfac

Patch Set 1 #

Total comments: 14

Patch Set 2 : resourceicon-* into mediumicon-* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -151 lines) Patch
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 21 chunks +83 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css View 2 chunks +10 lines, -88 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 2 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
lushnikov
please, take a look https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js File third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js (left): https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js#oldcode57 third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js:57: this, Common.UIString('Local Storage'), 'LocalStorage', ['table-tree-item', ...
3 years, 10 months ago (2017-01-30 12:50:36 UTC) #1
dgozman
https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css File third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css (left): https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css#oldcode116 third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css:116: -webkit-filter: invert(); Did you regress this or it just ...
3 years, 10 months ago (2017-01-30 16:47:53 UTC) #6
lushnikov
thank you for the review! please, take another look https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css File third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css (left): https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css#oldcode116 third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css:116: ...
3 years, 10 months ago (2017-01-31 03:17:32 UTC) #7
dgozman
lgtm https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css File third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css (right): https://codereview.chromium.org/2660893002/diff/1/third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css#newcode29 third_party/WebKit/Source/devtools/front_end/resources/resourcesSidebar.css:29: .navigator-tree-item { On 2017/01/31 03:17:32, lushnikov wrote: > ...
3 years, 10 months ago (2017-01-31 03:57:11 UTC) #10
lushnikov
thanks for the late-night review!
3 years, 10 months ago (2017-01-31 04:00:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660893002/20001
3 years, 10 months ago (2017-01-31 04:00:47 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 04:50:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b1dc85cf4ee7711aaf07585ec51...

Powered by Google App Engine
This is Rietveld 408576698