Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2660873003: PPC: Work-around to preserve sNan bit (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Work-around to preserve sNan bit On ia32/x64 when casting a sNan to double, the signalling bit is flipped to qNan. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2660873003 Cr-Commit-Position: refs/heads/master@{#42786} Committed: https://chromium.googlesource.com/v8/v8/+/c0f255f0756430eec913560b25aa6659480e3f0e

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 1 chunk +17 lines, -2 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/simulator-ppc.cc View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-01-30 18:16:00 UTC) #1
john.yan
lgtm with nits https://codereview.chromium.org/2660873003/diff/1/src/compiler/ppc/code-generator-ppc.cc File src/compiler/ppc/code-generator-ppc.cc (right): https://codereview.chromium.org/2660873003/diff/1/src/compiler/ppc/code-generator-ppc.cc#newcode2356 src/compiler/ppc/code-generator-ppc.cc:2356: ? 2141192192 using hex seems more ...
3 years, 10 months ago (2017-01-30 18:20:09 UTC) #2
JaideepBajwa
On 2017/01/30 18:20:09, john.yan wrote: > lgtm with nits > > https://codereview.chromium.org/2660873003/diff/1/src/compiler/ppc/code-generator-ppc.cc > File src/compiler/ppc/code-generator-ppc.cc ...
3 years, 10 months ago (2017-01-30 18:28:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660873003/20001
3 years, 10 months ago (2017-01-30 18:29:33 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:02:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c0f255f0756430eec913560b25aa6659480...

Powered by Google App Engine
This is Rietveld 408576698