DevTools: fix search across all files in case of "file:" prefix

DevTools: fix search across all files in case of "file:" prefix

Search across files supports narrowing of the search scope with the
"file:" pattern. For example:

   [1]    file:front_end QUERY
   [2]    QUERY file:front_end

The bug happens only in the [1] case, when the query is prefixed with
"file:" pattern. In this case, we currently consider the query
to be " foobar" instead of "foobar" (e.g. containing excessive space in
front).

This patch swallows all the whitespaces around the "file:" pattern so
that they are not included in the actual search queries.

BUG=686359
R=dgozman

Review-Url: https://codereview.chromium.org/2660853002
Cr-Commit-Position: refs/heads/master@{#447196}
Committed: https://chromium.googlesource.com/chromium/src/+/0dee95e08944e4ca548b5bf874d34a3695fc7a93

[lushnikov, 2017-01-30 10:03:42]

please, take a look

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js
(right):

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:62: var
quotedPattern = /"([^\\"]|\\.)+"/;
these are just strings re-written as regex literals. Twice less escaping!

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:69:
'(\\s*' + Workspace.SearchConfig.FilePatternRegex.source + '\\s*)',
the "\\s*" is the bugfix - swallowing of the whitespaces

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:152:
query = match[3];
but here we still want to use only the actual file path, without trailing
spaces. We can't just trimRight since some spaces could be escaped with '\'

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:174:
Workspace.SearchConfig.FilePatternRegex = /(-)?f(ile)?:((?:[^\\ ]|\\.)+)/;
this is the "filePattern" regex, written as regex literal and with one of the
groups turned to be non-matching

[lushnikov, 2017-01-30 14:54:53]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 14:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-01-30 16:54:43]

lgtm

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js
(right):

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:65: var
unquotedPattern = unquotedWordPattern.source + '( +' +
unquotedWordPattern.source + ')*';
I'm curious why we use ' ' instead of '\s' ?

[commit-bot: I haz the power, 2017-01-30 17:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 17:15:23]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-01-31 02:47:21]

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js
(right):

https://codereview.chromium.org/2660853002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/SearchConfig.js:65: var
unquotedPattern = unquotedWordPattern.source + '( +' +
unquotedWordPattern.source + ')*';
On 2017/01/30 16:54:42, dgozman wrote:
> I'm curious why we use ' ' instead of '\s' ?

Looks like there's no good reason. Updated the CL to use \s

[lushnikov, 2017-01-31 02:47:27]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-01-31 02:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2660853002/#ps20001
(title: "use \s instead of space")

[commit-bot: I haz the power, 2017-01-31 02:48:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 05:47:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485830847840550,
"parent_rev": "14c9281bb6a538be7e6d7f278d4fea7d5e838d08", "commit_rev":
"0dee95e08944e4ca548b5bf874d34a3695fc7a93"}

[commit-bot: I haz the power, 2017-01-31 05:48:26]

Description was changed from

==========
DevTools: fix search across all files in case of "file:" prefix

Search across files supports narrowing of the search scope with the
"file:" pattern. For example:

   [1]    file:front_end QUERY
   [2]    QUERY file:front_end

The bug happens only in the [1] case, when the query is prefixed with
"file:" pattern. In this case, we currently consider the query
to be " foobar" instead of "foobar" (e.g. containing excessive space in
front).

This patch swallows all the whitespaces around the "file:" pattern so
that they are not included in the actual search queries.

BUG=686359
R=dgozman
==========

to

==========
DevTools: fix search across all files in case of "file:" prefix

Search across files supports narrowing of the search scope with the
"file:" pattern. For example:

   [1]    file:front_end QUERY
   [2]    QUERY file:front_end

The bug happens only in the [1] case, when the query is prefixed with
"file:" pattern. In this case, we currently consider the query
to be " foobar" instead of "foobar" (e.g. containing excessive space in
front).

This patch swallows all the whitespaces around the "file:" pattern so
that they are not included in the actual search queries.

BUG=686359
R=dgozman

Review-Url: https://codereview.chromium.org/2660853002
Cr-Commit-Position: refs/heads/master@{#447196}
Committed:
https://chromium.googlesource.com/chromium/src/+/0dee95e08944e4ca548b5bf874d3...
==========

[commit-bot: I haz the power, 2017-01-31 05:48:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0dee95e08944e4ca548b5bf874d3...