Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2660823002: ThinStrings: fix Factory::NewProperSubString (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ThinStrings: fix Factory::NewProperSubString BUG=chromium:685504 Review-Url: https://codereview.chromium.org/2660823002 Cr-Commit-Position: refs/heads/master@{#42783} Committed: https://chromium.googlesource.com/v8/v8/+/7438304229b57a88f0b9857922f806af32718a80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M src/factory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-685504.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
PTAL.
3 years, 10 months ago (2017-01-30 06:57:51 UTC) #6
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 08:25:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660823002/1
3 years, 10 months ago (2017-01-30 18:22:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:24:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7438304229b57a88f0b9857922f806af327...

Powered by Google App Engine
This is Rietveld 408576698