Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: services/video_capture/test/mock_device_unittest.cc

Issue 2660743002: Merge video_capture tests into service_unittests (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/video_capture/test/mock_device_unittest.cc
diff --git a/services/video_capture/test/mock_device_unittest.cc b/services/video_capture/test/mock_device_unittest.cc
index 40f36b4e7b52ab68e4a2bcab768f36ec95e4c591..b0f7d427d96dea081714a005cfd7246fb191b0ca 100644
--- a/services/video_capture/test/mock_device_unittest.cc
+++ b/services/video_capture/test/mock_device_unittest.cc
@@ -10,9 +10,14 @@ using testing::Invoke;
namespace video_capture {
+// This alias ensures test output is easily attributed to this service's tests.
+// TODO(rockot/chfremer): Consider just renaming the type.
+using MockVideoCaptureDeviceTest = MockDeviceTest;
+
// Tests that the service stops the capture device when the client closes the
// connection to the device proxy.
-TEST_F(MockDeviceTest, DISABLED_DeviceIsStoppedWhenDiscardingDeviceProxy) {
+TEST_F(MockVideoCaptureDeviceTest,
+ DISABLED_DeviceIsStoppedWhenDiscardingDeviceProxy) {
base::RunLoop wait_loop;
// The mock device must hold on to the device client that is passed to it.
@@ -34,7 +39,8 @@ TEST_F(MockDeviceTest, DISABLED_DeviceIsStoppedWhenDiscardingDeviceProxy) {
// Tests that the service stops the capture device when the client closes the
// connection to the client proxy it provided to the service.
-TEST_F(MockDeviceTest, DISABLED_DeviceIsStoppedWhenDiscardingDeviceClient) {
+TEST_F(MockVideoCaptureDeviceTest,
+ DISABLED_DeviceIsStoppedWhenDiscardingDeviceClient) {
base::RunLoop wait_loop;
// The mock device must hold on to the device client that is passed to it.
« no previous file with comments | « services/video_capture/test/fake_device_unittest.cc ('k') | services/video_capture/test/service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698