Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: services/video_capture/test/fake_device_unittest.cc

Issue 2660743002: Merge video_capture tests into service_unittests (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/video_capture/test/fake_device_unittest.cc
diff --git a/services/video_capture/test/fake_device_unittest.cc b/services/video_capture/test/fake_device_unittest.cc
index b8751c8559c57468141ae98565a6ecd1f2e90067..11b107ed3fdea7dd5d774eaa641ddc21b7dc92ae 100644
--- a/services/video_capture/test/fake_device_unittest.cc
+++ b/services/video_capture/test/fake_device_unittest.cc
@@ -10,7 +10,6 @@
#include "services/video_capture/public/interfaces/device_factory.mojom.h"
#include "services/video_capture/test/fake_device_test.h"
#include "services/video_capture/test/mock_receiver.h"
-#include "services/video_capture/test/service_test.h"
using testing::_;
using testing::Invoke;
@@ -30,7 +29,11 @@ struct FrameInfo {
namespace video_capture {
-TEST_F(FakeDeviceTest, DISABLED_FrameCallbacksArrive) {
+// This alias ensures test output is easily attributed to this service's tests.
+// TODO(rockot/chfremer): Consider just renaming the type.
+using FakeVideoCaptureDeviceTest = FakeDeviceTest;
+
+TEST_F(FakeVideoCaptureDeviceTest, DISABLED_FrameCallbacksArrive) {
base::RunLoop wait_loop;
// These two constants must be static as a workaround
// for a MSVC++ bug about lambda captures, see the discussion at
@@ -54,7 +57,8 @@ TEST_F(FakeDeviceTest, DISABLED_FrameCallbacksArrive) {
// Tests that frames received from a fake capture device match the requested
// format and have increasing timestamps.
-TEST_F(FakeDeviceTest, DISABLED_ReceiveFramesFromFakeCaptureDevice) {
+TEST_F(FakeVideoCaptureDeviceTest,
+ DISABLED_ReceiveFramesFromFakeCaptureDevice) {
base::RunLoop wait_loop;
mojom::ReceiverPtr receiver_proxy;
// These two constants must be static as a workaround
« no previous file with comments | « services/video_capture/test/fake_device_descriptor_unittest.cc ('k') | services/video_capture/test/mock_device_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698