Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2660713002: Convert DevToolsUIBindings to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert DevToolsUIBindings to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2660713002 Cr-Commit-Position: refs/heads/master@{#446849} Committed: https://chromium.googlesource.com/chromium/src/+/db083e38d3c9c61b3b0d3f1b1eebed7d62f7b062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-01-27 21:19:57 UTC) #5
dgozman
lgtm
3 years, 10 months ago (2017-01-27 23:51:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660713002/1
3 years, 10 months ago (2017-01-28 00:25:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 00:34:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db083e38d3c9c61b3b0d3f1b1eeb...

Powered by Google App Engine
This is Rietveld 408576698