Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Issue 2660693002: bluetooth: Fix failing connection test (Closed)

Created:
3 years, 10 months ago by ortuno
Modified:
3 years, 10 months ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Fix failing connection test https://github.com/w3c/testharness.js/commit/7716e2581a86dfd9405a9c00547a7504f0c7fe94 started failing tests if there were unhandled errors during tests. This caused server/connect/garbage-collection-ran-during-error.html to fail because 'device.gatt.connect()' rejects. BUG=685863 Review-Url: https://codereview.chromium.org/2660693002 Cr-Commit-Position: refs/heads/master@{#446859} Committed: https://chromium.googlesource.com/chromium/src/+/1ad4baf8846d1f6875ceb6b9fe95090720d756fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/server/connect/garbage-collection-ran-during-error-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
ortuno
scheib: PTAL
3 years, 10 months ago (2017-01-27 22:05:13 UTC) #6
scheib
lgtm
3 years, 10 months ago (2017-01-28 00:39:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660693002/1
3 years, 10 months ago (2017-01-28 00:40:20 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 00:49:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ad4baf8846d1f6875ceb6b9fe95...

Powered by Google App Engine
This is Rietveld 408576698