[ES6 Modules] Introduce ModuleScriptFetchRequest

[ES6 Modules] Introduce ModuleScriptFetchRequest

This CL introduces ModuleScriptFetchRequest, a parameter object which
will be used to represent arguments of the spec "fetch a single module script"
algorithm:
https://html.spec.whatwg.org/#fetch-a-single-module-script

For a graphical mapping to the spec concept, please see:
https://docs.google.com/spreadsheets/d/1tofYrhZrTl605CHk95VVj_1HN7lOkQ3C7D-5NRful4s/edit#gid=0

BUG=594639
Review-Url: https://codereview.chromium.org/2660663002
Cr-Commit-Position: refs/heads/master@{#447620}
Committed: https://chromium.googlesource.com/chromium/src/+/662f25082427e46ee802aa95ed883a0132e682e5

[kouhei (in TOK), 2017-01-27 19:25:20]

kouhei@chromium.org changed reviewers:
+ domenic@chromium.org, dominicc@chromium.org, toyoshim@chromium.org,
yhirano@chromium.org

[kouhei (in TOK), 2017-01-27 20:30:48]

kouhei@chromium.org changed reviewers:
+ hiroshige@chromium.org

[domenic, 2017-01-27 20:40:29]

lgtm

[kouhei (in TOK), 2017-01-27 20:41:37]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:42:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:42:08]

This CL has an open dependency (Issue 2643003002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[hiroshige, 2017-01-27 20:47:09]

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h
(right):

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:18:
// arguments.
Adding the part of CL description:
> a parameter object which will be used to represent arguments
> of the spec "fetch a single module script" algorithm:
> https://html.spec.whatwg.org/#fetch-a-single-module-script
as a comment here will be helpful.

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:19:
class ModuleScriptFetchRequest {
Add final.

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:19:
class ModuleScriptFetchRequest {
If this should work only as a parameter object, can we specify STACK_ALLOCATED()
here?

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:55:
KURL m_url;
Can we specify |const| for these members?

[kouhei (in TOK), 2017-01-30 17:11:04]

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h
(right):

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:18:
// arguments.
On 2017/01/27 20:47:08, hiroshige wrote:
> Adding the part of CL description:
> > a parameter object which will be used to represent arguments
> > of the spec "fetch a single module script" algorithm:
> > https://html.spec.whatwg.org/#fetch-a-single-module-script
> as a comment here will be helpful.

Done.

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:19:
class ModuleScriptFetchRequest {
On 2017/01/27 20:47:09, hiroshige wrote:
> Add final.

Done.

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:19:
class ModuleScriptFetchRequest {
On 2017/01/27 20:47:08, hiroshige wrote:
> If this should work only as a parameter object, can we specify
STACK_ALLOCATED()
> here?

Done.

https://codereview.chromium.org/2660663002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:55:
KURL m_url;
On 2017/01/27 20:47:09, hiroshige wrote:
> Can we specify |const| for these members?

Done.

[yhirano, 2017-01-30 18:04:28]

https://codereview.chromium.org/2660663002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h
(right):

https://codereview.chromium.org/2660663002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:34:
nullAtom) {}
Can you use Referrer::noReferrer() instead?

[kouhei (in TOK), 2017-01-30 18:08:24]

https://codereview.chromium.org/2660663002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h
(right):

https://codereview.chromium.org/2660663002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/modulescript/ModuleScriptFetchRequest.h:34:
nullAtom) {}
On 2017/01/30 18:04:28, yhirano wrote:
> Can you use Referrer::noReferrer() instead?

Done.

[yhirano, 2017-01-30 18:09:14]

lgtm

[kouhei (in TOK), 2017-02-01 19:52:11]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2017-02-01 19:52:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
domenic@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2660663002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2017-02-01 19:52:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-02-01 19:56:37]

lgtm

[commit-bot: I haz the power, 2017-02-01 21:53:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485978731961980,
"parent_rev": "496a750d382e5ff646318d04f85e8bcd02a48ff9", "commit_rev":
"662f25082427e46ee802aa95ed883a0132e682e5"}

[commit-bot: I haz the power, 2017-02-01 21:58:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485978731961980,
"parent_rev": "496a750d382e5ff646318d04f85e8bcd02a48ff9", "commit_rev":
"662f25082427e46ee802aa95ed883a0132e682e5"}

[commit-bot: I haz the power, 2017-02-01 21:58:46]

Description was changed from

==========
[ES6 Modules] Introduce ModuleScriptFetchRequest

This CL introduces ModuleScriptFetchRequest, a parameter object which
will be used to represent arguments of the spec "fetch a single module script"
algorithm:
https://html.spec.whatwg.org/#fetch-a-single-module-script

For a graphical mapping to the spec concept, please see:
https://docs.google.com/spreadsheets/d/1tofYrhZrTl605CHk95VVj_1HN7lOkQ3C7D-5N...

BUG=594639
==========

to

==========
[ES6 Modules] Introduce ModuleScriptFetchRequest

This CL introduces ModuleScriptFetchRequest, a parameter object which
will be used to represent arguments of the spec "fetch a single module script"
algorithm:
https://html.spec.whatwg.org/#fetch-a-single-module-script

For a graphical mapping to the spec concept, please see:
https://docs.google.com/spreadsheets/d/1tofYrhZrTl605CHk95VVj_1HN7lOkQ3C7D-5N...

BUG=594639

Review-Url: https://codereview.chromium.org/2660663002
Cr-Commit-Position: refs/heads/master@{#447620}
Committed:
https://chromium.googlesource.com/chromium/src/+/662f25082427e46ee802aa95ed88...
==========

[commit-bot: I haz the power, 2017-02-01 21:58:48]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/662f25082427e46ee802aa95ed88...