LayoutTab fade animations should not block layouts

LayoutTab fade animations should not block layouts

Layouts in chrome do not finish transitions until all animations are
completed. Because of this, tab driven animations can block chrome's
UI. Particularly, theme color transitions will cause color fading
effects in the tab switcher. For example, if the tab is updating the
theme color faster than the animations complete, the animations never
end. These animations should not be considered when performing layout
transitions that are critical to chrome's function.

After this change, LayoutTab animations will no longer affect a layout
animation's completion state. If the animation is not complete, it
will request an update from the renerer, but it will no longer block
the UI.

BUG=627066
Review-Url: https://codereview.chromium.org/2660653002
Cr-Commit-Position: refs/heads/master@{#447137}
Committed: https://chromium.googlesource.com/chromium/src/+/27f8a728708b1ee8a3db41afcf47537a601d5abf

[mdjones, 2017-01-27 19:10:32]

Description was changed from

==========
LayoutTab fade animations should not block layouts

Layouts in chrome do not finish transitions until all animations are
completed. Because of this, tab driven animations can block chrome's
UI. Particularly, theme color transitions will cause color fading
effects in the tab switcher. For example, if the tab is updating the
theme color at 60fps, the animations never end. These animations
should not be considered when performing layout transitions that are
critical to chrome's function.

After this change, LayoutTab animations will no longer affect a layout
animation's completion state. If the animation is not complete, it
will request an update from the renerer, but it will no longer block
the UI.

BUG=627066
==========

to

==========
LayoutTab fade animations should not block layouts

Layouts in chrome do not finish transitions until all animations are
completed. Because of this, tab driven animations can block chrome's
UI. Particularly, theme color transitions will cause color fading
effects in the tab switcher. For example, if the tab is updating the
theme color faster than the animations complete, the animations never
end. These animations should not be considered when performing layout
transitions that are critical to chrome's function.

After this change, LayoutTab animations will no longer affect a layout
animation's completion state. If the animation is not complete, it
will request an update from the renerer, but it will no longer block
the UI.

BUG=627066
==========

[mdjones, 2017-01-27 19:10:57]

mdjones@chromium.org changed reviewers:
+ aelias@chromium.org

[mdjones, 2017-01-27 19:10:57]

ptal

[aelias_OOO_until_Jul13, 2017-01-27 20:09:16]

So the idea is that in LayoutManager.onUpdate, doneHiding should be called after
the particular hide animation completes, right?  Could we instead pass in a
callback to the particular hide animation for it to call when it completes,
instead of doing this global return value thing?

[mdjones, 2017-01-27 22:43:40]

On 2017/01/27 20:09:16, aelias wrote:
> So the idea is that in LayoutManager.onUpdate, doneHiding should be called
after
> the particular hide animation completes, right?  Could we instead pass in a
> callback to the particular hide animation for it to call when it completes,
> instead of doing this global return value thing?

As discussed offline, I think we need a more complete animation system to
support this kind of functionality. Our current animation system is a state
machine based on a collection of individual animatable properties, so there's no
single "exit tab switcher" animation to watch.

I tried listening to individual properties and calling doneHiding(), but I ended
up needing to add a bunch of state because animation properties are reused. This
solution was ugly and didn't work completely.

Until we get time to build a proper animation system I think the current
solution isn't too bad, but I'll leave that up to you.

[aelias_OOO_until_Jul13, 2017-01-27 22:45:57]

OK, lgtm I guess, please link the crbug in the comment for future reference.

[mdjones, 2017-01-31 00:03:15]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-01-31 00:03:15]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2660653002/#ps20001
(title: "add bug to comment")

[commit-bot: I haz the power, 2017-01-31 00:04:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 00:44:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485820995117050,
"parent_rev": "bc7ab72c78b36430b6c77078d2ad9790d1bf79c0", "commit_rev":
"27f8a728708b1ee8a3db41afcf47537a601d5abf"}

[commit-bot: I haz the power, 2017-01-31 00:45:11]

Description was changed from

==========
LayoutTab fade animations should not block layouts

Layouts in chrome do not finish transitions until all animations are
completed. Because of this, tab driven animations can block chrome's
UI. Particularly, theme color transitions will cause color fading
effects in the tab switcher. For example, if the tab is updating the
theme color faster than the animations complete, the animations never
end. These animations should not be considered when performing layout
transitions that are critical to chrome's function.

After this change, LayoutTab animations will no longer affect a layout
animation's completion state. If the animation is not complete, it
will request an update from the renerer, but it will no longer block
the UI.

BUG=627066
==========

to

==========
LayoutTab fade animations should not block layouts

Layouts in chrome do not finish transitions until all animations are
completed. Because of this, tab driven animations can block chrome's
UI. Particularly, theme color transitions will cause color fading
effects in the tab switcher. For example, if the tab is updating the
theme color faster than the animations complete, the animations never
end. These animations should not be considered when performing layout
transitions that are critical to chrome's function.

After this change, LayoutTab animations will no longer affect a layout
animation's completion state. If the animation is not complete, it
will request an update from the renerer, but it will no longer block
the UI.

BUG=627066

Review-Url: https://codereview.chromium.org/2660653002
Cr-Commit-Position: refs/heads/master@{#447137}
Committed:
https://chromium.googlesource.com/chromium/src/+/27f8a728708b1ee8a3db41afcf47...
==========

[commit-bot: I haz the power, 2017-01-31 00:45:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/27f8a728708b1ee8a3db41afcf47...