Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2660643003: Convert BrowserStatusMonitor to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert BrowserStatusMonitor to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2660643003 Cr-Commit-Position: refs/heads/master@{#447056} Committed: https://chromium.googlesource.com/chromium/src/+/8d41c4f901f69a8cc900f143fa67b05381a12e2f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 2 chunks +7 lines, -3 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
jam
3 years, 10 months ago (2017-01-27 21:20:12 UTC) #7
Mr4D (OOO till 08-26)
https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launcher/browser_status_monitor.cc File chrome/browser/ui/ash/launcher/browser_status_monitor.cc (right): https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launcher/browser_status_monitor.cc#newcode44 chrome/browser/ui/ash/launcher/browser_status_monitor.cc:44: !navigation_handle->HasCommitted()) Just checking: Is it guaranteed that we will ...
3 years, 10 months ago (2017-01-30 16:28:25 UTC) #8
jam
https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launcher/browser_status_monitor.cc File chrome/browser/ui/ash/launcher/browser_status_monitor.cc (right): https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launcher/browser_status_monitor.cc#newcode44 chrome/browser/ui/ash/launcher/browser_status_monitor.cc:44: !navigation_handle->HasCommitted()) On 2017/01/30 16:28:25, Mr4D wrote: > Just checking: ...
3 years, 10 months ago (2017-01-30 16:36:59 UTC) #9
Mr4D (OOO till 08-26)
lgtm
3 years, 10 months ago (2017-01-30 16:41:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660643003/1
3 years, 10 months ago (2017-01-30 20:12:36 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:48:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d41c4f901f69a8cc900f143fa67...

Powered by Google App Engine
This is Rietveld 408576698