Convert BrowserStatusMonitor to use the new navigation callbacks.

Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG=682002
Review-Url: https://codereview.chromium.org/2660643003
Cr-Commit-Position: refs/heads/master@{#447056}
Committed: https://chromium.googlesource.com/chromium/src/+/8d41c4f901f69a8cc900f143fa67b05381a12e2f

[jam, 2017-01-27 20:31:51]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2017-01-27 20:32:04]

Description was changed from

==========
Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG=682002
==========

[jam, 2017-01-27 20:32:04]

jam@chromium.org changed reviewers:
+ skuhne@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 21:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 21:05:28]

Dry run: This issue passed the CQ dry run.

[Mr4D (OOO till 08-26), 2017-01-30 16:28:25]

https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/browser_status_monitor.cc (right):

https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/browser_status_monitor.cc:44:
!navigation_handle->HasCommitted())
Just checking: Is it guaranteed that we will be called again once it has been
committed?

[jam, 2017-01-30 16:36:59]

https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launc...
File chrome/browser/ui/ash/launcher/browser_status_monitor.cc (right):

https://codereview.chromium.org/2660643003/diff/1/chrome/browser/ui/ash/launc...
chrome/browser/ui/ash/launcher/browser_status_monitor.cc:44:
!navigation_handle->HasCommitted())
On 2017/01/30 16:28:25, Mr4D wrote:
> Just checking: Is it guaranteed that we will be called again once it has been
> committed?

This line is to keep parity between the old code: DidNavigateMainFrame was only
called for successful main frame navigations. DidFinishNavigation is called for
all frames (first part of if statement) and for navigations that don't go
through (i.e. downloads, 204/205s) (2nd part).

[Mr4D (OOO till 08-26), 2017-01-30 16:41:11]

lgtm

[jam, 2017-01-30 20:11:51]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-01-30 20:12:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 20:47:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485807111407390, "parent_rev":
"4d848d233f32e00446f04971e388a62295ff1a5d", "commit_rev":
"8d41c4f901f69a8cc900f143fa67b05381a12e2f"}

[commit-bot: I haz the power, 2017-01-30 20:48:24]

Description was changed from

==========
Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG=682002
==========

to

==========
Convert BrowserStatusMonitor to use the new navigation callbacks.

BUG=682002

Review-Url: https://codereview.chromium.org/2660643003
Cr-Commit-Position: refs/heads/master@{#447056}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d41c4f901f69a8cc900f143fa67...
==========

[commit-bot: I haz the power, 2017-01-30 20:48:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d41c4f901f69a8cc900f143fa67...