Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.cc

Issue 2660643002: Use an OOPIF-compatible call chain when finding the top-level frame (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_autofill_agent.cc
diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc
index 2d8f6c9177b394dcded406d730647744d3e3bc09..565e9aca6300cacb6b987984fad375ca06b7ba2c 100644
--- a/components/autofill/content/renderer/password_autofill_agent.cc
+++ b/components/autofill/content/renderer/password_autofill_agent.cc
@@ -853,12 +853,10 @@ bool PasswordAutofillAgent::ShowSuggestions(
if ((element.isPasswordField() ||
HasAutocompleteAttributeValue(element, "username")) &&
security_state::IsHttpWarningInFormEnabled() &&
- !content::IsOriginSecure(url::Origin(render_frame()
- ->GetRenderView()
- ->GetMainRenderFrame()
- ->GetWebFrame()
- ->getSecurityOrigin())
- .GetURL())) {
+ !content::IsOriginSecure(
+ url::Origin(
+ render_frame()->GetWebFrame()->top()->getSecurityOrigin())
nasko 2017/01/27 21:43:35 Can't we use getSecurityOrigin().isPotentiallyTrus
+ .GetURL())) {
autofill_agent_->ShowNotSecureWarning(element);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698