Use an OOPIF-compatible call chain when finding the top-level frame

components/autofill/content/renderer/password_autofill_agent.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_autofill_agent.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
@@ skipping 835 matching lines @@
   blink::WebInputElement password_element;
   PasswordInfo* password_info;
 
   if (!FindPasswordInfoForElement(element, &username_element, &password_element,
                                   &password_info)) {
     // If we don't have a password stored, but the form is non-secure, warn
     // the user about the non-secure form.
     if ((element.isPasswordField() ||
          HasAutocompleteAttributeValue(element, "username")) &&
         security_state::IsHttpWarningInFormEnabled() &&
-        !content::IsOriginSecure(url::Origin(render_frame()
-                                                 ->GetRenderView()
-                                                 ->GetMainRenderFrame()
-                                                 ->GetWebFrame()
-                                                 ->getSecurityOrigin())
-                                     .GetURL())) {
+        !content::IsOriginSecure(
+            url::Origin(
+                render_frame()->GetWebFrame()->top()->getSecurityOrigin())

[nasko, 2017/01/27 21:43:35]

Can't we use getSecurityOrigin().isPotentiallyTrustworthy() here? The multiple
conversions going on are too hard to follow and might lead to subtle mistakes.

+                .GetURL())) {
       autofill_agent_->ShowNotSecureWarning(element);
       return true;
     }
     return false;
   }
 
   // If autocomplete='off' is set on the form elements, no suggestion dialog
   // should be shown. However, return |true| to indicate that this is a known
   // password form and that the request to show suggestions has been handled (as
   // a no-op).
@@ skipping 647 matching lines @@
 PasswordAutofillAgent::GetPasswordManagerDriver() {
   if (!password_manager_driver_) {
     render_frame()->GetRemoteInterfaces()->GetInterface(
         mojo::MakeRequest(&password_manager_driver_));
   }
 
   return password_manager_driver_;
 }
 
 }  // namespace autofill