Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: ui/views/view.cc

Issue 2660593002: Paint text cursor in LAYER_SOLID_COLOR (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/view.cc
diff --git a/ui/views/view.cc b/ui/views/view.cc
index 04c5f2fae25957c3ca3b706654e263fc8b3c6638..6d1c7f8c66be0e98f3f88a5704741f2a5cc4d165 100644
--- a/ui/views/view.cc
+++ b/ui/views/view.cc
@@ -298,8 +298,13 @@ void View::RemoveChildView(View* view) {
}
void View::RemoveAllChildViews(bool delete_children) {
- while (!children_.empty())
+ while (!children_.empty()) {
+ const char* class_name = children_.front()->GetClassName();
+ LOG(ERROR) << "now removing child " << class_name;
DoRemoveChildView(children_.front(), false, false, delete_children, NULL);
+ LOG(ERROR) << "After removing child " << class_name << " root view is "
+ << GetWidget()->GetRootView();
+ }
sadrul 2017/02/13 20:33:30 Remove these changes?
yiyix 2017/02/13 21:12:23 so sorry, i fixed the changes but i forget to save
UpdateTooltip();
}
« ui/views/controls/textfield/textfield.cc ('K') | « ui/views/controls/textfield/textfield.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698